test(ai-review): 補使用量統計 NaN 安全測試並排除微優化誤報 #47

Merged

admin merged 15 commits from develop into master 2026-06-23 09:35:54 +00:00

Conversation 1 Commits 15 Files Changed 5

+654 -543

jiantw83 commented 2026-06-23 09:35:38 +00:00

Member

Copy Link

Copy Source

No description provided.

jiantw83 added 15 commits 2026-06-23 09:35:39 +00:00

test(ai-review 使用量): 補 formatUsageStatsLine 對 NaN/異常數字輸出安全文字測試 6398d4a193

chore(ai-review 狀態): 補 NaN 測試、排除 recordRateLimit 微優化誤報，清空 findings.json 1ff74297ce

chore: update ai-review findings [ai-review-bot][failure] d7e5bee65e

fix(ai-review 使用量): resolveRemainingPercent 要求有限正數上限，避免 Infinity 上限算出 NaN%／負百分比 6259cd4398

test(ai-review 使用量): 補 quota/rate 上限為 0/負數/Infinity/NaN 與剩餘非有限的邊界測試 791449161f

chore(ai-review 狀態): 解決邊界數值 findings、排除唯讀 fixture 誤報，清空 findings.json 0aee3459e6

chore: update ai-review findings [ai-review-bot][failure] 0fdd6c1d0b

chore(ai-review 狀態): 排除 3 條誤報（測試已涵蓋／風格／isFinitePositive 已安全），清空 findings.json 0d0298b005

chore: update ai-review findings [ai-review-bot][failure] 655cd77421

fix(usage 剩餘百分比): 抽出 calculatePercent 共用函式並修正剩餘值缺失時誤算 0% ... bd9a3111fa

剩餘值為 null/undefined 時原本經 Number() 轉成 0 而算出 0%，
改由 calculatePercent 統一檢查有效性，無效值一律落到「無法計算」。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fix(ai-review exclusions): 修正追加排除規則時讀寫目錄顛倒導致既有規則被覆蓋 ... fcde1b0bc9

appendExclusions 原以 WORKSPACE 為主、repoDir 為鏡像，與 loadExclusions 相反，
會讀到空的 WORKSPACE 後把僅含本次新增的結果鏡像覆蓋掉 repoDir 既有規則，
改為以 repoDir 為主、WORKSPACE 為鏡像，順序與 loadExclusions 一致。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

test(usage 剩餘百分比): 補 rate.remaining 為 null/undefined 時不計算百分比的測試 ... ec8773d54d

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

chore(ai-review 狀態): 還原被覆蓋的 108 條排除規則並清空 findings ... feae0d91de

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

chore: update ai-review findings [ai-review-bot][success] 78127cf51c

Merge pull request 'test(ai-review): 補使用量統計 NaN 安全測試並排除微優化誤報' (#46) from ai-review-resolve/20260623-163642 into develop ... 3763908b39

Reviewed-on: actions/code-review#46

admin approved these changes 2026-06-23 09:35:51 +00:00

admin merged commit 65f18ec0b7 into master 2026-06-23 09:35:54 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

admin

Labels

No items

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

admin (系統管理員) jiantw83 (Jeffery)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: old-actions/code-review#47