chore: triage review findings

.gitea/ai-review/exclusions.json

@@ -279,5 +279,33 @@
   {
     "location": "app/json.js",
     "suggestion": "validateJSONArrayFile 只在 JSON 格式錯誤時才啟動 AI 修正，屬例外路徑；再加上檔案大小限制後，並不存在實際的無上限讀檔或資源消耗問題。"
+  },
+  {
+    "location": "app/json.test.js",
+    "suggestion": "邊界值測試已存在，`MAX_JSON_BYTES` 等於上限時可正常讀取，這不是未解決問題。"
+  },
+  {
+    "location": "app/gitea.test.js:64",
+    "suggestion": "`describe` 已改為同步 callback，`async` 不再出現在這個區塊。"
+  },
+  {
+    "location": "app/git.test.js:13",
+    "suggestion": "`makeTmpWorkspace` 已直接使用 `app/git.js` 匯出的 `SYNC_PATHS`，不再維護重複清單。"
+  },
+  {
+    "location": "app/gitea.js:32",
+    "suggestion": "`filterDiff` 內層縮排已符合專案的 2-space 風格，這是誤報。"
+  },
+  {
+    "location": "app/json.test.js:76",
+    "suggestion": "1MB 上限下的 JSON 讀取不需要改成串流解析；現有實作已先做大小檢查，這個建議屬過度設計。"
+  },
+  {
+    "location": "app/json.test.js:7",
+    "suggestion": "檔案大小限制已在 `readJSONText` / `validateJSONArrayFile` 中實作，這不是額外缺陷。"
+  },
+  {
+    "location": "app/json.test.js:10",
+    "suggestion": "`MAX_JSON_BYTES` 是 `json.js` 的內部限制常數，不需要匯出成公開 API。"
   }
 ]

.gitea/ai-review/findings.json

@@ -1,30 +1 @@
-[
-  {
-    "level": "warning",
-    "role": "Maya",
-    "location": "app/json.test.js",
-    "suggestion": "在 `readJSONText` 相關的測試中，除了測試檔案過大的情況，也建議增加一個測試案例，驗證當檔案大小剛好等於 `MAX_JSON_BYTES` 時，檔案能夠被成功讀取且不會拋出錯誤。這能確保邊界條件的處理是正確的。",
-    "is_new": false
-  },
-  {
-    "level": "warning",
-    "role": "Aria",
-    "location": "app/gitea.js:14",
-    "suggestion": "陣列字面量過長，建議將每個元素放在獨立一行，以提高可讀性。例如：\n`return filterDiff(resp.data, [\n  '.gitea/',\n  '.amazonq/',\n  '.claude/',\n  '.codex/',\n  '.gemini/',\n  '.github/',\n  'CLAUDE.md',\n  'GEMINI.md',\n  'TODO.md',\n  'README.md'\n]);`",
-    "is_new": true
-  },
-  {
-    "level": "warning",
-    "role": "Aria",
-    "location": "app/gitea.test.js:64",
-    "suggestion": "`describe` 區塊的回呼函數不應使用 `async` 關鍵字。`describe` 區塊應同步執行，而異步操作應在 `it` 或 `beforeEach` 等鉤子函數中處理。",
-    "is_new": true
-  },
-  {
-    "level": "info",
-    "role": "Maya",
-    "location": "app/json.test.js",
-    "suggestion": "在 `validateJSONArrayFile` 函數中，寫入修復後的 JSON 時，有判斷是否需要添加換行符 (`repaired.endsWith('\\n') ? repaired : `${repaired}\\n``)。目前的測試案例只驗證了最終結果包含換行符，但沒有明確測試兩種情況：當 AI 回傳的內容已經包含換行符時，以及不包含換行符時，都能正確處理。建議增加一個測試案例來覆蓋這兩種情況。",
-    "is_new": false
-  }
-]
+[]

app/git.js

@@ -4,7 +4,7 @@ import path from 'path';
 import { GITEA_SERVER_URL, GITEA_REPOSITORY, GITEA_TOKEN, PR_HEAD_BRANCH, FINDINGS_PATH } from './config.js';
 
 const remoteUrl = `${GITEA_SERVER_URL.replace(/\/$/, '')}/${GITEA_REPOSITORY}.git`;
-const SYNC_PATHS = [
+export const SYNC_PATHS = [
   FINDINGS_PATH,
   '.amazonq/rules/triage-findings.md',
   '.claude/skills/triage-findings/SKILL.md',

app/git.test.js

@@ -3,24 +3,14 @@ import assert from 'node:assert/strict';
 import fs from 'fs';
 import os from 'os';
 import path from 'path';
-import { commitAndPush, cloneRepo } from './git.js';
+import { commitAndPush, cloneRepo, SYNC_PATHS } from './git.js';
 
 // --- helpers ---
 function makeTmpWorkspace() {
   const ws = fs.mkdtempSync(path.join(os.tmpdir(), 'git-test-'));
   // Pre-create repo dir so clone branch is skipped
   fs.mkdirSync(path.join(ws, 'repo'), { recursive: true });
-  const files = [
-    '.gitea/ai-review/findings.json',
-    '.amazonq/rules/triage-findings.md',
-    '.claude/skills/triage-findings/SKILL.md',
-    '.gemini/skills/triage-findings/SKILL.md',
-    '.github/copilot-instructions.md',
-    '.github/skills/triage-findings/SKILL.md',
-    'CLAUDE.md',
-    'GEMINI.md',
-  ];
-  for (const relPath of files) {
+  for (const relPath of SYNC_PATHS) {
     const fullPath = path.join(ws, relPath);
     fs.mkdirSync(path.dirname(fullPath), { recursive: true });
     fs.writeFileSync(fullPath, relPath);

app/gitea.js

@@ -12,16 +12,16 @@ const api = (path) => `${GITEA_SERVER_URL.replace(/\/$/, '')}/api/v1${path}`;
 export async function getPRDiff() {
   const resp = await axios.get(api(`/repos/${GITEA_REPOSITORY}/pulls/${PR_NUMBER}.diff`), { headers: headers(), timeout: 60000, httpsAgent });
   return filterDiff(resp.data, [
-    '.gitea/',
     '.amazonq/',
     '.claude/',
     '.codex/',
     '.gemini/',
+    '.gitea/',
     '.github/',
     'CLAUDE.md',
     'GEMINI.md',
-    'TODO.md',
     'README.md',
+    'TODO.md',
   ]);
 }