Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 12980d6ca4 | |||
| aa8b3ae89a |
@@ -9,22 +9,22 @@
|
||||
{
|
||||
"level": "warning",
|
||||
"role": "Aria",
|
||||
"location": "app/gitea.js:14",
|
||||
"suggestion": "陣列字面量過長,建議將每個元素放在獨立一行,以提高可讀性。例如:\n`return filterDiff(resp.data, [\n '.gitea/',\n '.amazonq/',\n '.claude/',\n '.codex/',\n '.gemini/',\n '.github/',\n 'CLAUDE.md',\n 'GEMINI.md',\n 'TODO.md',\n 'README.md'\n]);`",
|
||||
"location": "app/gitea.test.js:64",
|
||||
"suggestion": "`describe` 區塊的回呼函數不應使用 `async` 關鍵字。`describe` 區塊應同步執行,而異步操作應在 `it` 或 `beforeEach` 等鉤子函數中處理。",
|
||||
"is_new": false
|
||||
},
|
||||
{
|
||||
"level": "warning",
|
||||
"role": "Leo",
|
||||
"location": "app/git.test.js:13",
|
||||
"suggestion": "在 `makeTmpWorkspace` 函式中,`files` 陣列的內容與 `app/git.js` 中的 `SYNC_PATHS` 常數高度重複。為了避免未來修改 `SYNC_PATHS` 時遺漏更新測試檔案,建議將 `SYNC_PATHS` 從 `app/git.js` 匯出,並在測試中直接引用,以確保兩者保持同步。",
|
||||
"is_new": true
|
||||
},
|
||||
{
|
||||
"level": "warning",
|
||||
"role": "Aria",
|
||||
"location": "app/gitea.test.js:64",
|
||||
"suggestion": "`describe` 區塊的回呼函數不應使用 `async` 關鍵字。`describe` 區塊應同步執行,而異步操作應在 `it` 或 `beforeEach` 等鉤子函數中處理。",
|
||||
"location": "app/gitea.js:32",
|
||||
"suggestion": "在 `filterDiff` 函數中,`excludePrefixes.some` 回呼函數內的程式碼區塊(`const prefix`, `const singleFile`, `return` 語句)的縮排不正確。請將這些行相對於 `p => {` 縮排 2 個空格,以符合專案的 2-space 縮排規範。",
|
||||
"is_new": true
|
||||
},
|
||||
{
|
||||
"level": "info",
|
||||
"role": "Maya",
|
||||
"location": "app/json.test.js",
|
||||
"suggestion": "在 `validateJSONArrayFile` 函數中,寫入修復後的 JSON 時,有判斷是否需要添加換行符 (`repaired.endsWith('\\n') ? repaired : `${repaired}\\n``)。目前的測試案例只驗證了最終結果包含換行符,但沒有明確測試兩種情況:當 AI 回傳的內容已經包含換行符時,以及不包含換行符時,都能正確處理。建議增加一個測試案例來覆蓋這兩種情況。",
|
||||
"is_new": false
|
||||
}
|
||||
]
|
||||
|
||||
+1
-1
@@ -4,7 +4,7 @@ import path from 'path';
|
||||
import { GITEA_SERVER_URL, GITEA_REPOSITORY, GITEA_TOKEN, PR_HEAD_BRANCH, FINDINGS_PATH } from './config.js';
|
||||
|
||||
const remoteUrl = `${GITEA_SERVER_URL.replace(/\/$/, '')}/${GITEA_REPOSITORY}.git`;
|
||||
const SYNC_PATHS = [
|
||||
export const SYNC_PATHS = [
|
||||
FINDINGS_PATH,
|
||||
'.amazonq/rules/triage-findings.md',
|
||||
'.claude/skills/triage-findings/SKILL.md',
|
||||
|
||||
+2
-12
@@ -3,24 +3,14 @@ import assert from 'node:assert/strict';
|
||||
import fs from 'fs';
|
||||
import os from 'os';
|
||||
import path from 'path';
|
||||
import { commitAndPush, cloneRepo } from './git.js';
|
||||
import { commitAndPush, cloneRepo, SYNC_PATHS } from './git.js';
|
||||
|
||||
// --- helpers ---
|
||||
function makeTmpWorkspace() {
|
||||
const ws = fs.mkdtempSync(path.join(os.tmpdir(), 'git-test-'));
|
||||
// Pre-create repo dir so clone branch is skipped
|
||||
fs.mkdirSync(path.join(ws, 'repo'), { recursive: true });
|
||||
const files = [
|
||||
'.gitea/ai-review/findings.json',
|
||||
'.amazonq/rules/triage-findings.md',
|
||||
'.claude/skills/triage-findings/SKILL.md',
|
||||
'.gemini/skills/triage-findings/SKILL.md',
|
||||
'.github/copilot-instructions.md',
|
||||
'.github/skills/triage-findings/SKILL.md',
|
||||
'CLAUDE.md',
|
||||
'GEMINI.md',
|
||||
];
|
||||
for (const relPath of files) {
|
||||
for (const relPath of SYNC_PATHS) {
|
||||
const fullPath = path.join(ws, relPath);
|
||||
fs.mkdirSync(path.dirname(fullPath), { recursive: true });
|
||||
fs.writeFileSync(fullPath, relPath);
|
||||
|
||||
Reference in New Issue
Block a user