refactor: rename Step4 to AI 排除問題過濾

Co-authored-by: Copilot <copilot@github.com>

.gitea/ai-review/exclusions.json

@@ -3,61 +3,5 @@
     "role": "Rex",
     "location": "app/git.js",
     "suggestion": "請避免將敏感資料（如 GITEA_TOKEN）直接寫入環境變數"
-  },
-  {
-    "location": "app/git.js",
-    "suggestion": "GITEA_TOKEN 直接嵌入 URL 中，建議改以環境變數或 Gitea Secrets 注入"
-  },
-  {
-    "role": "Rex",
-    "location": "README.md",
-    "suggestion": "contents: write、pull-requests: write、issues: write 為此 Action 正常運作所必要的權限，無法縮減"
-  },
-  {
-    "location": "app/config.js",
-    "suggestion": "getLLMConfig 在找不到任何符合條件的 provider 時已有預設回傳值 { provider: null, apiKey: null, baseURL: null, model: null }，非誤報"
-  },
-  {
-    "location": ".gitea/ai-review/exclusions.json",
-    "suggestion": "exclusions.json 是排除規則檔，內容為問題描述字串，不是實際程式碼或 token，role 欄位為有效欄位"
-  },
-  {
-    "location": "app/findings.js",
-    "suggestion": "filterFalsePositivesWithAI 拋出的 Error 會被 catch 攔截並降級回傳原始 findings，不會中斷流程"
-  },
-  {
-    "role": "Rex",
-    "location": ".gitea/workflows/review.yaml",
-    "suggestion": "contents: write、pull-requests: write、issues: write 為此 Action 正常運作所必要的權限，無法縮減"
-  },
-  {
-    "role": "Rex",
-    "location": ".gitea/workflows/review.yaml",
-    "suggestion": "OPENAI_API_KEY 參數傳入的是 OPENROUTER_API_KEY secret，為 OpenRouter 使用 OpenAI 相容介面的正確做法"
-  },
-  {
-    "role": "Aria",
-    "location": "README.md",
-    "suggestion": "章節編號連續且正確，無需調整"
-  },
-  {
-    "role": "Maya",
-    "location": ".gitea/workflows/review.yaml",
-    "suggestion": "action.yaml 定義的參數名稱為 GEMINI_API_KEY、GEMINI_BASE_URL、GEMINI_MODEL，與 review.yaml 完全一致，無不匹配問題"
-  },
-  {
-    "role": "Aria",
-    "location": ".gitea/workflows/review.yaml",
-    "suggestion": "review.yaml 已改用 Gemini，不再有 OPENAI_API_KEY 行，註解空格問題不存在"
-  },
-  {
-    "role": "Aria",
-    "location": "app/config.test.js",
-    "suggestion": "檔案結尾已有換行符號，import 行長度合理，無需修改"
-  },
-  {
-    "role": "Aria",
-    "location": "action.yaml",
-    "suggestion": "action.yaml 已整理，多餘空行已移除，結構整潔"
   }
 ]

.gitea/ai-review/findings.json

@@ -1,107 +1,114 @@
 [
-  {
-    "level": "critical",
-    "role": "Maya",
-    "location": ".gitea/workflows/review.yaml:35-37 與 action.yaml",
-    "suggestion": "在 `review.yaml` 工作流程中，您嘗試傳遞 `GEMINI_API_KEY`、`GEMINI_BASE_URL` 和 `GEMINI_MODEL` 參數。然而，根據 `action.yaml` 的定義，此 Action 預期接收的是 `GOOGLE_API_KEY`、`GOOGLE_BASE_URL` 和 `GOOGLE_MODEL`。這導致參數名稱不匹配，Action 將無法正確取得 Gemini 的設定，進而導致功能失效。請修正 `review.yaml`，將參數名稱改為 `GOOGLE_API_KEY`、`GOOGLE_BASE_URL` 和 `GOOGLE_MODEL`，以符合 `action.yaml` 中已定義的 Google 相關輸入。",
-    "is_new": true
-  },
   {
     "level": "warning",
-    "role": "Aria",
-    "location": ".gitea/workflows/review.yaml:33",
-    "suggestion": "在 `OPENAI_API_KEY` 後的註解前應保留一個空格，以符合常見的 YAML 註解風格：`... ${{ secrets.OPENROUTER_API_KEY }}  # OpenRouter 使用 OpenAI 相容介面，以 OPENAI_API_KEY 傳入`。",
+    "role": "Rex",
+    "location": "app/git.js:14",
+    "suggestion": "在 cloneRepo 函數中，請確保 GIT_TOKEN 不會被寫入到檔案系統中，避免敏感資訊洩漏。",
     "is_new": false
   },
   {
     "level": "warning",
-    "role": "Aria",
-    "location": ".gitea/ai-review/findings.json",
-    "suggestion": "檔案最後缺少換行符號，請在檔案結尾加入一個空白換行。",
+    "role": "Leo",
+    "location": "app/findings.js:93",
+    "suggestion": "建議在 loadExclusions 函式中增加對於 JSON 格式的驗證，確保讀取的資料符合預期格式，避免潛在的錯誤。",
     "is_new": false
   },
   {
     "level": "warning",
-    "role": "Aria",
-    "location": "app/config.test.js",
-    "suggestion": "檔案最後缺少換行符號，請在檔案結尾加入空白換行。",
+    "role": "Leo",
+    "location": "app/findings.js:40",
+    "suggestion": "在 applyExclusions 函式中，建議增加對於 findings 和 exclusions 參數的有效性檢查，以提高程式的健壯性。",
     "is_new": false
   },
   {
     "level": "warning",
-    "role": "Aria",
-    "location": "action.yaml:72-99",
-    "suggestion": "大量移除的輸入欄位留下多行空白與註解，請整理檔案結構，移除不必要的空行與註解，保持檔案整潔。",
+    "role": "Zara",
+    "location": "app/findings.js:40",
+    "suggestion": "在 applyExclusions 函數中，使用 Array.prototype.some 進行過濾時，可能會導致性能問題，特別是當 findings 和 exclusions 的數量都很大時。建議使用更高效的資料結構（如 HashSet）來加速查詢。",
     "is_new": false
   },
-  {
-    "level": "warning",
-    "role": "Aria",
-    "location": ".gitea/workflows/review.yaml:36",
-    "suggestion": "`secrets.GEMINI_API_KEY_1` 的命名方式建議審視。如果這是唯一的 Gemini API 金鑰，可考慮簡化為 `GEMINI_API_KEY`。若有多個金鑰，建議使用更具描述性的後綴（例如 `GEMINI_API_KEY_PRIMARY` 或 `GEMINI_API_KEY_SERVICE_A`），以提升命名清晰度與一致性。",
-    "is_new": true
-  },
   {
     "level": "warning",
     "role": "Maya",
-    "location": "app/",
-    "suggestion": "此次變更將 AI 審查服務從 OpenRouter 切換至 Gemini。儘管 `action.yaml` 中已存在 `GOOGLE_*` 相關的輸入，但此 Git Diff 並未包含任何針對 Gemini API 整合的單元測試或整合測試。請確認現有的測試是否足以涵蓋 Gemini API 的特定行為、回應格式以及錯誤處理。若無，建議為 Gemini 整合新增專屬的整合測試，以確保其在實際運作中的穩定性與正確性，特別是針對 `https://generativelanguage.googleapis.com/v1beta` 這個 Base URL 和所選的 `GEMINI_MODEL`。",
-    "is_new": true
-  },
-  {
-    "level": "info",
-    "role": "Aria",
-    "location": "app/config.test.js",
-    "suggestion": "匯入語句過長，建議改寫為多行匯入，例如：\n```js\nimport {\n  describe,\n  it,\n  beforeEach,\n  afterEach\n} from 'node:test';\n```",
-    "is_new": false
-  },
-  {
-    "level": "info",
-    "role": "Aria",
-    "location": "app/config.test.js",
-    "suggestion": "`ENV_KEYS` 陣列過長，建議分行列舉，每行放置一個環境變數，以提升可讀性。",
+    "location": "app/findings.js:40",
+    "suggestion": "建議在 applyExclusions 函數中增加對 findings 內容的驗證，確保其格式正確，以提高測試的穩定性和可靠性。",
     "is_new": false
   },
   {
     "level": "info",
     "role": "Leo",
-    "location": "app/config.test.js:1",
-    "suggestion": "匯入語句過長，建議改寫為多行匯入，以提升可讀性，例如：\n```js\nimport {\n  describe,\n  it,\n  beforeEach,\n  afterEach\n} from 'node:test';\n```",
+    "location": "README.md",
+    "suggestion": "建議在 README 中增加對於新功能（如排除問題過濾）的詳細說明，以便未來的維護者能快速了解其功能。",
     "is_new": false
   },
   {
     "level": "info",
     "role": "Leo",
-    "location": "app/config.test.js:9",
-    "suggestion": "`ENV_KEYS` 陣列過長，建議分行列舉，每行放置一個環境變數，以提升可讀性與維護性。",
-    "is_new": false
-  },
-  {
-    "level": "info",
-    "role": "Aria",
-    "location": "app/config.test.js:1",
-    "suggestion": "匯入語句過長，建議改寫為多行匯入，例如：\n```js\nimport {\n  describe,\n  it,\n  beforeEach,\n  afterEach\n} from 'node:test';\n```",
-    "is_new": false
-  },
-  {
-    "level": "info",
-    "role": "Aria",
-    "location": "app/config.test.js:7",
-    "suggestion": "`ENV_KEYS` 陣列過長，建議每行放置一個環境變數，分行列舉以提升可讀性。",
-    "is_new": false
-  },
-  {
-    "level": "info",
-    "role": "Aria",
-    "location": ".gitea/workflows/review.yaml:33",
-    "suggestion": "在 `OPENAI_API_KEY` 後的註解前保留一個空格，以符合常見的 YAML 註解風格：`... ${{ secrets.OPENROUTER_API_KEY }}  # OpenRouter 使用 OpenAI 相容介面，以 OPENAI_API_KEY 傳入`。",
+    "location": "app/main.js",
+    "suggestion": "建議在 main 函式中增加對於每個步驟的詳細註解，讓未來的維護者能更容易理解程式邏輯。",
     "is_new": false
   },
   {
     "level": "info",
     "role": "Zara",
-    "location": ".gitea/workflows/review.yaml:35-37",
-    "suggestion": "工作流程從 OpenRouter/OpenAI 服務切換至 Google Gemini 服務。雖然這本身不是程式碼錯誤，但不同 AI 服務提供商的 API 響應時間、吞吐量和穩定性可能存在差異。建議監控切換後 AI Code Review 步驟的執行時間，確保新配置能維持或提升效能，並留意潛在的成本變化。",
-    "is_new": true
+    "location": "app/findings.js:39",
+    "suggestion": "在過濾 findings 時，建議將過濾條件的邏輯提取為獨立函數，以提高可讀性和可維護性。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Zara",
+    "location": "app/main.js:64",
+    "suggestion": "在讀取排除問題檔案時，建議考慮使用非同步方法（如 fs.promises.readFile）來避免阻塞事件循環，提升效能。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Aria",
+    "location": "README.md:8",
+    "suggestion": "建議將「如果PR問題表格中有嚴重問題，則不要讓 workflow 執行成功(exit 1)」的描述改為「如果 PR 問題表格中有嚴重問題，則不要讓 workflow 執行成功（exit 1）」以提高可讀性。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Aria",
+    "location": "TODO.md:4",
+    "suggestion": "建議將「階段四：findings 寫入與 comment 發布」的標題改為「階段四：排除問題過濾」，以更清楚地反映內容。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Aria",
+    "location": "app/config.js",
+    "suggestion": "建議在 EXCLUSIONS_PATH 的定義上方添加註解，說明該常數的用途，以提高可讀性。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Aria",
+    "location": "app/findings.js",
+    "suggestion": "建議在 loadExclusions 函數的開頭添加註解，說明該函數的用途，以提高可讀性。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Aria",
+    "location": "app/findings.js",
+    "suggestion": "建議在 applyExclusions 函數的開頭添加註解，說明該函數的用途，以提高可讀性。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Maya",
+    "location": "app/findings.js:7",
+    "suggestion": "建議為 loadExclusions 和 applyExclusions 函數撰寫單元測試，以確保其功能正確並能處理邊界條件。",
+    "is_new": false
+  },
+  {
+    "level": "info",
+    "role": "Maya",
+    "location": "app/main.js:48",
+    "suggestion": "建議在每個主要步驟之後增加測試用例，以驗證每個步驟的輸出是否符合預期。",
+    "is_new": false
   }
-]
+]

.gitea/workflows/review.yaml

@@ -33,9 +33,8 @@ jobs:
     - name: AI Code Review
       uses: https://gitea.jsc.idv.tw/jiantw83/code-review@v${{ needs.version.outputs.version }}
       with:
-        GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY_1 }}
-        GEMINI_BASE_URL: https://generativelanguage.googleapis.com/v1beta
-        GEMINI_MODEL: ${{ vars.GEMINI_MODEL }}
+        OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
+        OPENAI_BASE_URL: https://openrouter.ai/api/v1
     permissions:
       contents: write
       pull-requests: write

README.md

@@ -6,8 +6,8 @@
 
 1. 服務名稱、模型名稱、角色資訊(個性、符合個性的英文名稱、工作內容)，Comment 到 Push Request
 2. 每個角色個別分析 Git Diff 的內容產生新問題表格(問題等級、角色名稱、問題位置或行數、修改建議)
-3. 讀取所有未解決的舊問題(問題檔案 `.gitea/ai-review/findings.json` 存在於使用此 Action 的專案固定位置)加上新問題後，去除重複產生本次 Push Request 的問題表格(PR問題表格)覆蓋問題檔案
-4. 讀取排除問題檔案(`.gitea/ai-review/exclusions.json` 存在於使用此 Action 的專案固定位置)，用來過濾PR問題表格中不需要處理的問題
+3. 讀取所有未解決的舊問題(問題檔案存在於使用此 Action 的專案固定位置)加上新問題後，去除重複產生本次 Push Request 的問題表格(PR問題表格)覆蓋問題檔案
+4. 讀取排除問題檔案，用來過濾PR問題表格中不需要處理的問題
 5. 從PR問題表格中取出所有舊問題，依照等級排序後 Comment 到 Push Request
 6. 從PR問題表格中取出所有新問題，排除嚴重等級的問題後 Comment 到 Push Request
 7. 從PR問題表格中取出所有新問題，將每個嚴重等級的問題 Comment 到 Push Request
@@ -28,7 +28,7 @@
 2. 在 `.gitea/workflows` 資料夾中建立 `ai-review.yaml'
 3. 在 `ai-review.yaml` 中填入以下內容(選擇一個使用)：
 
-### 1. OpenAI
+### 1. OpenAI（OpenRouter）
 ```yaml
 name: AI
 on:
@@ -42,39 +42,17 @@ jobs:
     - name: AI Code Review
       uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
       with:
+        # Github (h3285@evertrust.com.tw)
+        # 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
         OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
-        OPENAI_BASE_URL: https://api.openai.com/v1
-        OPENAI_MODEL: ${{ vars.OPENAI_MODEL }}
-    permissions:
-      contents: write
-      pull-requests: write
-      issues: write
-```
-
-### 2. OpenRouter
-```yaml
-name: AI
-on:
-  pull_request:
-    types: [opened, synchronize]
-jobs:
-  code-review:
-    name: 'Code Review'
-    runs-on: ubuntu
-    steps:
-    - name: AI Code Review
-      uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
-      with:
-        OPENAI_API_KEY: ${{ secrets.OPENROUTER_API_KEY }}  # OpenRouter 使用 OpenAI 相容介面，以 OPENAI_API_KEY 傳入
         OPENAI_BASE_URL: https://openrouter.ai/api/v1
-        OPENAI_MODEL: ${{ vars.OPENROUTER_MODEL }}
     permissions:
       contents: write
       pull-requests: write
       issues: write
 ```
 
-### 3. Anthropic Claude
+### 2. Anthropic Claude
 ```yaml
 name: AI
 on:
@@ -96,7 +74,7 @@ jobs:
       issues: write
 ```
 
-### 4. Google Gemini
+### 3. Google Gemini
 ```yaml
 name: AI
 on:
@@ -112,14 +90,13 @@ jobs:
       with:
         GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }}
         GEMINI_BASE_URL: https://generativelanguage.googleapis.com/v1beta
-        GEMINI_MODEL: ${{ vars.GEMINI_MODEL }}
     permissions:
       contents: write
       pull-requests: write
       issues: write
 ```
 
-### 5. Amazon Q
+### 4. Amazon Q
 ```yaml
 name: AI
 on:
@@ -141,6 +118,28 @@ jobs:
       issues: write
 ```
 
+### 5. SonarQube
+```yaml
+name: AI
+on:
+  pull_request:
+    types: [opened, synchronize]
+jobs:
+  code-review:
+    name: 'Code Review'
+    runs-on: ubuntu
+    steps:
+    - name: AI Code Review
+      uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
+      with:
+        SONARQUBE_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
+        SONARQUBE_URL: https://sonarqube.example.com
+    permissions:
+      contents: write
+      pull-requests: write
+      issues: write
+```
+
 ### - Ollama
 
 ```yaml
@@ -156,7 +155,7 @@ jobs:
     - name: AI Code Review
         uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
         with:
-          OLLAMA_BASE_URL: https://ollama.jsc.idv.me/v1
+          OLLAMA_BASE_URL: ${{ vars.OLLAMA_BASE_URL }}
           OLLAMA_MODEL: ${{ vars.OLLAMA_MODEL }}
     permissions:
       contents: write

TODO.md

@@ -16,13 +16,13 @@
 - 完成
 
 ## 階段四：AI 排除問題過濾
-- 目標：讀取排除問題檔案（`.gitea/ai-review/exclusions.json`）進行規則過濾，並呼叫 AI 判斷剩餘問題是否為誤報或不適用，兩層過濾後產生最終問題清單。
+- 目標：讀取排除問題檔案（exclusions.json）進行規則過濾，並呼叫 AI 判斷剩餘問題是否為誤報或不適用，兩層過濾後產生最終問題清單。
 - 驗收：log 中能看到排除問題檔案讀取成功或不存在的訊息、規則過濾數量變化，以及「AI 誤報過濾: N -> M 筆」或降級訊息。
 - 完成
 
 ## 階段五：findings 寫入與 comment 發布
-- 目標：`.gitea/ai-review/findings.json` 正確寫入，comment 發布順序正確（舊問題→非嚴重→嚴重），每步有 log。
-- 驗收：log 中能看到 `.gitea/ai-review/findings.json` 寫入、comment sync 的詳細訊息與順序。
+- 目標：findings.jsonl 正確寫入，comment 發布順序正確（舊問題→非嚴重→嚴重），每步有 log。
+- 驗收：log 中能看到 findings.json 寫入、comment sync 的詳細訊息與順序。
 - 完成
 
 ## 階段六：記憶區 commit/push 與錯誤處理

action.yaml

@@ -72,6 +72,54 @@ inputs:
     description: 'Amazon Q Base URL'
     required: false
 
+  # SonarQube
+  SONARQUBE_TOKEN:
+    description: 'SonarQube Token'
+    required: false
+  SONARQUBE_URL:
+    description: 'SonarQube URL'
+    required: false
+
+  # Kilo Code
+  KILO_API_KEY:
+    description: 'Kilo Code API Key'
+    required: false
+  KILO_BASE_URL:
+    description: 'Kilo Code Base URL'
+    required: false
+
+  # Roo Code
+  ROO_API_KEY:
+    description: 'Roo Code API Key'
+    required: false
+  ROO_BASE_URL:
+    description: 'Roo Code Base URL'
+    required: false
+
+  # Cline
+  CLINE_API_KEY:
+    description: 'Cline API Key'
+    required: false
+  CLINE_BASE_URL:
+    description: 'Cline Base URL'
+    required: false
+
+  # Continue
+  CONTINUE_API_KEY:
+    description: 'Continue API Key'
+    required: false
+  CONTINUE_BASE_URL:
+    description: 'Continue Base URL'
+    required: false
+
+  # Kade
+  KADE_API_KEY:
+    description: 'Kade API Key'
+    required: false
+  KADE_BASE_URL:
+    description: 'Kade Base URL'
+    required: false
+
 runs:
   using: 'docker'
   image: 'Dockerfile'
@@ -97,3 +145,15 @@ runs:
     OLLAMA_MODEL: ${{ inputs.OLLAMA_MODEL }}
     AMAZONQ_API_KEY: ${{ inputs.AMAZONQ_API_KEY }}
     AMAZONQ_BASE_URL: ${{ inputs.AMAZONQ_BASE_URL }}
+    SONARQUBE_TOKEN: ${{ inputs.SONARQUBE_TOKEN }}
+    SONARQUBE_URL: ${{ inputs.SONARQUBE_URL }}
+    KILO_API_KEY: ${{ inputs.KILO_API_KEY }}
+    KILO_BASE_URL: ${{ inputs.KILO_BASE_URL }}
+    ROO_API_KEY: ${{ inputs.ROO_API_KEY }}
+    ROO_BASE_URL: ${{ inputs.ROO_BASE_URL }}
+    CLINE_API_KEY: ${{ inputs.CLINE_API_KEY }}
+    CLINE_BASE_URL: ${{ inputs.CLINE_BASE_URL }}
+    CONTINUE_API_KEY: ${{ inputs.CONTINUE_API_KEY }}
+    CONTINUE_BASE_URL: ${{ inputs.CONTINUE_BASE_URL }}
+    KADE_API_KEY: ${{ inputs.KADE_API_KEY }}
+    KADE_BASE_URL: ${{ inputs.KADE_BASE_URL }}

app/config.js

@@ -12,9 +12,14 @@ export function getLLMConfig() {
   const checks = [
     ['openai',   process.env.OPENAI_API_KEY,   process.env.OPENAI_BASE_URL || 'https://api.openai.com/v1',   process.env.OPENAI_MODEL || 'gpt-4o-mini'],
     ['claude',   process.env.CLAUDE_API_KEY,   process.env.CLAUDE_BASE_URL || 'https://api.anthropic.com/v1', process.env.CLAUDE_MODEL || 'claude-3-haiku-20240307'],
-    ['gemini',   process.env.GEMINI_API_KEY,   process.env.GEMINI_BASE_URL || 'https://generativelanguage.googleapis.com/v1beta', process.env.GEMINI_MODEL || 'gemini-2.5-flash'],
+    ['gemini',   process.env.GEMINI_API_KEY,   process.env.GEMINI_BASE_URL || 'https://generativelanguage.googleapis.com/v1beta', process.env.GEMINI_MODEL || 'gemini-1.5-flash'],
     ['ollama',   'ollama',                      process.env.OLLAMA_BASE_URL,  process.env.OLLAMA_MODEL],
-    ['amazonq',  process.env.AMAZONQ_API_KEY,  process.env.AMAZONQ_BASE_URL  || 'https://q.api.aws',              process.env.AMAZONQ_MODEL  || 'amazon-q'],
+    ['amazonq',  process.env.AMAZONQ_API_KEY,  process.env.AMAZONQ_BASE_URL || 'https://q.api.aws', process.env.OPENAI_MODEL || 'amazon-q'],
+    ['kilo',     process.env.KILO_API_KEY,     process.env.KILO_BASE_URL || 'https://api.kilocode.com/v1', process.env.OPENAI_MODEL || 'kilo-default'],
+    ['roo',      process.env.ROO_API_KEY,      process.env.ROO_BASE_URL || 'https://api.roocode.com/v1', process.env.OPENAI_MODEL || 'roo-default'],
+    ['cline',    process.env.CLINE_API_KEY,    process.env.CLINE_BASE_URL || 'https://api.cline.dev/v1', process.env.OPENAI_MODEL || 'cline-default'],
+    ['continue', process.env.CONTINUE_API_KEY, process.env.CONTINUE_BASE_URL || 'https://api.continue.dev/v1', process.env.OPENAI_MODEL || 'continue-default'],
+    ['kade',     process.env.KADE_API_KEY,     process.env.KADE_BASE_URL || 'https://api.kade.dev/v1', process.env.OPENAI_MODEL || 'kade-default'],
   ];
   for (const [provider, key, baseURL, model] of checks) {
     if (key && baseURL) return { provider, apiKey: key, baseURL, model };

app/config.test.js

@@ -1,101 +0,0 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
-import assert from 'node:assert/strict';
-import { getLLMConfig } from './config.js';
-
-const ENV_KEYS = [
-  'OPENAI_API_KEY', 'OPENAI_BASE_URL', 'OPENAI_MODEL',
-  'CLAUDE_API_KEY', 'CLAUDE_BASE_URL', 'CLAUDE_MODEL',
-  'GEMINI_API_KEY', 'GEMINI_BASE_URL', 'GEMINI_MODEL',
-  'OLLAMA_BASE_URL', 'OLLAMA_MODEL',
-  'AMAZONQ_API_KEY', 'AMAZONQ_BASE_URL', 'AMAZONQ_MODEL',
-];
-
-let saved = {};
-beforeEach(() => {
-  saved = {};
-  for (const k of ENV_KEYS) { saved[k] = process.env[k]; delete process.env[k]; }
-});
-afterEach(() => {
-  for (const k of ENV_KEYS) {
-    if (saved[k] === undefined) delete process.env[k];
-    else process.env[k] = saved[k];
-  }
-});
-
-describe('getLLMConfig', () => {
-  it('returns null provider when no env vars set', () => {
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, null);
-    assert.equal(cfg.apiKey, null);
-  });
-
-  it('detects openai with defaults', () => {
-    process.env.OPENAI_API_KEY = 'sk-test';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'openai');
-    assert.equal(cfg.apiKey, 'sk-test');
-    assert.equal(cfg.baseURL, 'https://api.openai.com/v1');
-    assert.equal(cfg.model, 'gpt-4o-mini');
-  });
-
-  it('detects openai with custom base url and model', () => {
-    process.env.OPENAI_API_KEY = 'sk-test';
-    process.env.OPENAI_BASE_URL = 'https://openrouter.ai/api/v1';
-    process.env.OPENAI_MODEL = 'gpt-4o';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'openai');
-    assert.equal(cfg.baseURL, 'https://openrouter.ai/api/v1');
-    assert.equal(cfg.model, 'gpt-4o');
-  });
-
-  it('detects gemini with defaults', () => {
-    process.env.GEMINI_API_KEY = 'gemini-key';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'gemini');
-    assert.equal(cfg.model, 'gemini-2.5-flash');
-  });
-
-  it('detects gemini with custom model', () => {
-    process.env.GEMINI_API_KEY = 'gemini-key';
-    process.env.GEMINI_MODEL = 'gemini-2.0-flash';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.model, 'gemini-2.0-flash');
-  });
-
-  it('detects claude with defaults', () => {
-    process.env.CLAUDE_API_KEY = 'claude-key';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'claude');
-    assert.equal(cfg.model, 'claude-3-haiku-20240307');
-  });
-
-  it('detects amazonq with its own model env', () => {
-    process.env.AMAZONQ_API_KEY = 'aq-key';
-    process.env.AMAZONQ_MODEL = 'my-amazon-model';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'amazonq');
-    assert.equal(cfg.model, 'my-amazon-model');
-  });
-
-  it('openai takes priority over gemini when both set', () => {
-    process.env.OPENAI_API_KEY = 'sk-test';
-    process.env.GEMINI_API_KEY = 'gemini-key';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'openai');
-  });
-
-  it('empty string api key is treated as not set', () => {
-    process.env.OPENAI_API_KEY = '';
-    process.env.GEMINI_API_KEY = 'gemini-key';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'gemini');
-  });
-
-  it('detects ollama without api key', () => {
-    process.env.OLLAMA_BASE_URL = 'http://localhost:11434';
-    process.env.OLLAMA_MODEL = 'llama3';
-    const cfg = getLLMConfig();
-    assert.equal(cfg.provider, 'ollama');
-    assert.equal(cfg.model, 'llama3');
-  });
-});

app/findings.js

@@ -117,50 +117,43 @@ export function loadExclusions(workspace) {
 
 /**
  * 套用排除規則，過濾掉符合排除條件的 findings
- * location 只比對檔案路徑（忽略行數），suggestion 省略時視為萬用
+ * 排除條件：role/location/suggestion 皆符合（省略的欄位視為萬用）
  */
 export function applyExclusions(findings, exclusions) {
   if (exclusions.length === 0) return findings;
   const before = findings.length;
-  const filtered = findings.filter(f => !exclusions.some(ex => {
-    const fPath = String(f.location).split(':')[0];
-    const exPath = ex.location ? String(ex.location).split(':')[0] : null;
-    return (!exPath || fPath === exPath) &&
-           (!ex.role || ex.role === f.role);
-  }));
+  const filtered = findings.filter(f => !exclusions.some(ex =>
+    (!ex.role || ex.role === f.role) &&
+    (!ex.location || String(f.location).includes(ex.location)) &&
+    (!ex.suggestion || String(f.suggestion).includes(String(ex.suggestion).slice(0, 20)))
+  ));
   console.log(`  排除過濾: ${before} -> ${filtered.length} 筆（排除 ${before - filtered.length} 筆）`);
   return filtered;
 }
 
 /**
  * 呼叫 AI 判斷哪些問題是誤報或不需處理，回傳需保留的 findings
- * exclusions 為已知誤報清單，供 AI 參考判斷
  * 失敗時降級回傳原始 findings
  */
-export async function filterFalsePositivesWithAI(findings, exclusions = []) {
+export async function filterFalsePositivesWithAI(findings) {
   if (findings.length === 0) return findings;
 
-  const exclusionHint = exclusions.length > 0
-    ? `\n\n以下是已知的誤報或不需處理的問題清單（供參考，相同檔案路徑且語意相近的問題應一併排除）：\n${JSON.stringify(exclusions, null, 2)}`
-    : '';
-
   const systemPrompt = `你是一位資深程式碼審查專家，負責判斷審查問題是否為誤報或不需處理。
 給你一份問題清單（JSON 陣列），每筆包含 level、role、location、suggestion。
 請移除以下類型的問題：
 1. 誤報：問題描述與實際程式碼不符（例如：程式碼已正確使用環境變數或 secrets，卻被標記為硬編碼敏感資料）
 2. 不適用：問題在此專案情境下不需處理（例如：CI/CD action 本來就需要透過環境變數傳遞 token）
-3. 與已知誤報清單語意相近的問題（檔案路徑相同且建議內容相似）
-只回傳需要保留的問題 JSON 陣列，不要有其他文字。${exclusionHint}`;
+只回傳需要保留的問題 JSON 陣列，不要有其他文字。`;
 
   const userContent = `請判斷以下問題清單，移除誤報或不需處理的問題：\n\n${JSON.stringify(findings, null, 2)}`;
 
   try {
     const result = await chatJSON(systemPrompt, userContent);
-    if (Array.isArray(result) && result.length > 0) {
+    if (Array.isArray(result)) {
       console.log(`  AI 誤報過濾: ${findings.length} -> ${result.length} 筆`);
       return result;
     }
-    throw new Error('AI 回傳空陣列或非陣列');
+    throw new Error('AI 回傳非陣列');
   } catch (e) {
     const status = e.response?.status;
     if (status === 402 || status === 429) {

app/git.test.js

@@ -3,7 +3,7 @@ import assert from 'node:assert/strict';
 import fs from 'fs';
 import os from 'os';
 import path from 'path';
-import { commitAndPush, cloneRepo } from './git.js';
+import { commitAndPush } from './git.js';
 
 // --- helpers ---
 function makeTmpWorkspace() {
@@ -91,59 +91,3 @@ describe('commitAndPush', () => {
     await assert.doesNotReject(() => commitAndPush(workspace, failSpawn));
   });
 });
-
-describe('cloneRepo', () => {
-  let workspace;
-
-  before(() => { workspace = fs.mkdtempSync(path.join(os.tmpdir(), 'clone-test-')); });
-  after(() => { fs.rmSync(workspace, { recursive: true, force: true }); });
-
-  it('clones repo when repoDir does not exist', () => {
-    const spawn = makeSpawn();
-    cloneRepo(workspace, spawn);
-    const cloneCalled = spawn.calls.some(c => c.args[0] === 'clone');
-    assert.ok(cloneCalled, 'expected git clone to be called');
-  });
-
-  it('fetches and checks out when repoDir already exists', () => {
-    const repoDir = path.join(workspace, 'repo');
-    fs.mkdirSync(repoDir, { recursive: true });
-    const spawn = makeSpawn();
-    cloneRepo(workspace, spawn);
-    const cloneCalled = spawn.calls.some(c => c.args[0] === 'clone');
-    const fetchCalled = spawn.calls.some(c => c.args[0] === 'fetch');
-    assert.ok(!cloneCalled, 'clone should not run when repoDir exists');
-    assert.ok(fetchCalled, 'fetch should run when repoDir exists');
-  });
-
-  it('does not embed token in any git command argument', () => {
-    const spawn = makeSpawn();
-    cloneRepo(workspace, spawn);
-    for (const { args } of spawn.calls) {
-      assert.ok(!args.join(' ').includes('test-token'), `Token leaked in git args: ${args.join(' ')}`);
-    }
-  });
-
-  it('uses GIT_ASKPASS for network operations', () => {
-    const spawn = makeSpawn();
-    cloneRepo(workspace, spawn);
-    const networkCalls = spawn.calls.filter(c => ['clone', 'fetch'].includes(c.args[0]));
-    assert.ok(networkCalls.length > 0, 'expected at least one network git call');
-    for (const { args, opts } of networkCalls) {
-      assert.ok(opts?.env?.GIT_ASKPASS, `GIT_ASKPASS missing for git ${args[0]}`);
-    }
-  });
-
-  it('cleans up askpass script after run', () => {
-    const spawn = makeSpawn();
-    cloneRepo(workspace, spawn);
-    const leftover = fs.readdirSync(workspace).filter(f => f.endsWith('.git-askpass.sh'));
-    assert.equal(leftover.length, 0, 'askpass script was not cleaned up');
-  });
-
-  it('returns repoDir path', () => {
-    const spawn = makeSpawn();
-    const result = cloneRepo(workspace, spawn);
-    assert.equal(result, path.join(workspace, 'repo'));
-  });
-});

app/main.js

@@ -85,7 +85,7 @@ async function main() {
   console.log('\n🚫 Step4: AI 排除問題過濾');
   const exclusions = loadExclusions(repoDir || WORKSPACE);
   const ruleFiltered = applyExclusions(sorted, exclusions);
-  const filtered = await filterFalsePositivesWithAI(ruleFiltered, exclusions);
+  const filtered = await filterFalsePositivesWithAI(ruleFiltered);
   console.log(`  Step4 完成: findings total=${filtered.length}`);
 
   // Step5: 寫入 findings.json，依序發布 comment

app/roles.js

@@ -12,13 +12,9 @@ export function loadRoles() {
 }
 
 export function getRoleIntro(roles) {
-  const lines = [
-    '## 🤖 AI Code Review 團隊', '',
-    '| 👤 名稱 | 🎯 職責 | 🧠 個性 |',
-    '|--------|--------|--------|',
-  ];
+  const lines = ['## 🤖 AI Code Review 團隊', ''];
   for (const r of roles) {
-    lines.push(`| **${r.name}** | ${r.role} | ${r.personality} |`);
+    lines.push(`- **${r.name}** (${r.role})：${r.personality}`);
   }
   return lines.join('\n');
 }