Compare commits

...

25 Commits

Author SHA1 Message Date
jiantw83 66d93abe24 Merge pull request 'feat: master 不會觸發 review.yaml' (#66) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#66
2026-05-11 14:12:38 +00:00
AI Review Bot a4b87f9108 chore: update ai-review findings [skip ci] 2026-05-11 14:11:43 +00:00
jiantw83 09533ff741 feat: 改用分支名稱鎖定 review 工作流 2026-05-11 14:10:57 +00:00
AI Review Bot e217b18c62 chore: update ai-review findings [skip ci] 2026-05-11 14:09:25 +00:00
jiantw83 cd0ced1b7f feat: 同時只能有一個 review.yaml 執行 2026-05-11 14:08:40 +00:00
AI Review Bot 65cf45c558 chore: update ai-review findings [skip ci] 2026-05-11 14:06:55 +00:00
AI Review Bot 09c78835e7 chore: update ai-review findings [skip ci] 2026-05-11 14:06:17 +00:00
jiantw83 ec05ce7869 feat: 調整設定的順序 2026-05-11 14:06:09 +00:00
jiantw83 0063f3282f Merge pull request 'refactor: 改用 execSync' (#65) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#65
2026-05-11 13:56:13 +00:00
jiantw83 8c3d0d9a6d Merge pull request 'fix: add bash to Dockerfile dependencies' (#64) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#64
2026-05-11 10:54:08 +00:00
jiantw83 3849bb2168 Merge pull request 'fix: switch Dockerfile base image to alpine and install dependencies using apk' (#63) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#63
2026-05-11 10:46:43 +00:00
jiantw83 379938d6dc Merge pull request 'fix: Dockerfile 加入 git 安裝驗證,git.js 改回 git binary' (#62) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#62
2026-05-11 10:38:59 +00:00
jiantw83 5bf39966d0 Merge pull request 'fix: 換用 node:20 完整版(內建 git,不需要 apt-get)' (#61) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#61
2026-05-11 10:34:11 +00:00
jiantw83 3509a882e1 Merge pull request 'chore: add newline at end of TODO.md for better formatting' (#60) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#60
2026-05-11 10:19:46 +00:00
jiantw83 1d2e8236de Merge pull request 'chore: remove duplicate log assistance note in TODO.md' (#59) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#59
2026-05-11 10:18:13 +00:00
jiantw83 d8423c74b1 Merge pull request 'chore: remove test findings' (#58) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#58
2026-05-11 10:12:32 +00:00
jiantw83 94e974b5dc Merge pull request 'feat/refactor/kiro/1' (#57) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#57
2026-05-11 10:10:23 +00:00
jiantw83 a9a0b43ea5 Merge pull request 'debug: commit/push 失敗時顯示詳細錯誤' (#56) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#56
2026-05-11 10:04:49 +00:00
jiantw83 aa8234b5c7 Merge pull request 'fix: commitAndPush 加上 await' (#55) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#55
2026-05-11 10:01:12 +00:00
jiantw83 b0f2d45c11 Merge pull request 'fix: add newline at end of TODO.md for proper formatting' (#54) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#54
2026-05-11 09:59:14 +00:00
jiantw83 3fd9a7e13d Merge pull request 'feat: 階段五六 - findings commit/push 到來源分支,critical 問題 exit 1' (#53) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#53
2026-05-11 09:54:39 +00:00
jiantw83 39cc5c932c Merge pull request 'feat: 階段四 - findings 寫入與 comment 依序發布(舊問題→非嚴重→嚴重)' (#52) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#52
2026-05-11 09:48:41 +00:00
jiantw83 255adbabe4 Merge pull request 'feat: 階段三 - AI 語意去重,失敗時降級保留所有問題' (#51) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#51
2026-05-11 09:44:10 +00:00
jiantw83 a10fc8f176 Merge pull request 'feat/refactor/kiro/1' (#50) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#50
2026-05-11 09:40:12 +00:00
jiantw83 9b39908394 Merge pull request 'feat: 階段一 - 基本流程串接骨架' (#47) from feat/refactor/kiro/1 into feat/refactor/main
Reviewed-on: jiantw83/code-review#47
2026-05-11 07:53:38 +00:00
2 changed files with 11 additions and 64 deletions
+6 -62
View File
@@ -1,7 +1,7 @@
[
{
"level": "critical",
"role": "Rex",
"role": "Leo",
"location": "app/git.js:11",
"suggestion": "GITEA_TOKEN 直接嵌入 URL 中,可能導致憑證洩漏。建議使用環境變數或安全的憑證管理方式來處理敏感資訊。",
"is_new": true
@@ -16,41 +16,27 @@
{
"level": "warning",
"role": "Leo",
"location": "app/git.js:11",
"suggestion": "建議將 git 函式的實作細節封裝到一個獨立的模組中,以提高模組化和可重用性。",
"is_new": true
},
{
"level": "warning",
"role": "Leo",
"location": "app/git.js:41",
"suggestion": "建議在 try-catch 區塊中增加更詳細的錯誤處理,以便於未來的除錯和維護。",
"is_new": true
},
{
"level": "warning",
"role": "Zara",
"location": "app/git.js:25",
"suggestion": "在使用 fs.existsSync 檢查目錄是否存在時,應考慮使用非同步方法以避免阻塞事件循環。",
"is_new": true
},
{
"level": "warning",
"role": "Zara",
"role": "Leo",
"location": "app/git.js:29",
"suggestion": "在 git clone 時使用 --depth=1 可能會導致未來需要完整歷史紀錄時的性能問題,建議根據實際需求調整。",
"is_new": true
},
{
"level": "warning",
"role": "Rex",
"role": "Leo",
"location": "app/git.js:11",
"suggestion": "在使用 fs.copyFileSync 時,未檢查目標檔案是否存在,可能會覆蓋重要資料。建議在複製之前檢查檔案是否存在。",
"is_new": true
},
{
"level": "warning",
"role": "Maya",
"role": "Leo",
"location": "app/git.js:11",
"suggestion": "在 commitAndPush 函數中,對於 git 操作的錯誤處理不夠完善,應該添加更多的測試來驗證不同情況下的行為。",
"is_new": true
@@ -58,57 +44,15 @@
{
"level": "info",
"role": "Leo",
"location": "app/git.js:5",
"suggestion": "建議為函式添加 JSDoc 註解,以提高文件完整性和可讀性。",
"location": ".gitea/workflows/review.yaml:5",
"suggestion": "建議在 'branches-ignore' 前加上空行,以提高可讀性。",
"is_new": true
},
{
"level": "info",
"role": "Leo",
"location": "app/git.js:10",
"suggestion": "建議將常數如 'repo' 提取為變數,以提高可讀性和可維護性。",
"is_new": true
},
{
"level": "info",
"role": "Zara",
"location": "app/git.js:45",
"suggestion": "考慮使用 async/await 來處理 fs.copyFileSync,以提高可讀性和錯誤處理能力。",
"is_new": true
},
{
"level": "info",
"role": "Aria",
"location": "app/git.js:12",
"suggestion": "考慮將常量 GITEA_SERVER_URL、GITEA_REPOSITORY、GITEA_TOKEN、PR_HEAD_BRANCH 和 FINDINGS_PATH 的引入放在一起,以保持一致性。",
"is_new": true
},
{
"level": "info",
"role": "Aria",
"location": "app/git.js:41",
"suggestion": "在 console.log 的訊息中,考慮使用更具描述性的文字來提高可讀性。",
"is_new": true
},
{
"level": "info",
"role": "Aria",
"location": "app/git.js:43",
"suggestion": "考慮將錯誤處理的 console.log 訊息翻譯成英文,以保持一致性。",
"is_new": true
},
{
"level": "info",
"role": "Maya",
"location": "app/git.js:11",
"suggestion": "建議為 git 函數添加測試,以確保其在不同參數下的行為正確。",
"is_new": true
},
{
"level": "info",
"role": "Maya",
"location": "app/git.js:11",
"suggestion": "建議對 repoDir 的存在性檢查進行單元測試,以確保在不存在時能正確執行 clone 操作。",
"is_new": true
}
]
+5 -2
View File
@@ -1,9 +1,12 @@
name: AI
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref }}
cancel-in-progress: true
on:
pull_request:
types: [opened, synchronize]
branches-ignore:
- master
- master
types: [opened, synchronize]
jobs:
version:
name: 計算版本號