plugins/meta
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(skillset-report): 四支異動技能收尾套用到工作階段、驗證並寫異動報告

Browse Source 
What：`skill-new`、`skill-update`、`skill-delete`、`skillset-update` 四支各新增一個收尾步驟，內含三個子步驟：把改動套用到目前工作階段、逐項驗證功能真的動得起來、把驗證結果附加到 wiki 的 `SKILLSET_{HASH}`。四支的 `description` 同步補上這段收尾。

Why：原本四支都以「開了 PR」作為收尾。PR 開完技能還沒進到任何 CLI，改動到底動不動得起來沒人驗過，壞了要等下一次有人踩到才知道。技能組的異動紀錄也一樣沒有落腳處：同一支技能改過幾次、每次改了什麼，只能翻 git 紀錄。

How：套用那一步分兩條路徑，依改動走到哪裡決定。PR 已經合併到 `master` 才走 `jsc-cli:deploy` 更新模式，並依提示重新啟動；PR 還停在 `develop` 或還在等審核，就改用工作樹驗證，報告標成「工作樹驗證、尚未部署」，並點名還沒合併的發佈 PR。分兩條路徑的理由是完成條件達不到：marketplace 與 `version-guard.sh` 都讀存取庫的預設分支，停在 `develop` 的改動 `deploy` 一定看不到，硬跑就卡在永遠達不到的完成條件上。驗證那一步要求逐項比對結束碼與實際輸出，不接受「跑完沒報錯」；對不上就回到套用那一步重跑，不往下走。報告一律附加一節、不覆蓋舊節，要看一支技能改過幾次就在同一頁上翻；寫不進去就把頁名與未寫入的內容交回使用者，這一步留著不結案。

Who：`jsc-meta` 的四支技能組異動技能，以及日後查技能組異動紀錄的人。
This commit is contained in:
jiantw83
2026-08-27 16:34:16 +08:00
parent 9a0ea8e248
commit 478f670d53
4 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
skills/skill-delete/SKILL.md
+7 -1
View File
@@ -1,6 +1,6 @@
---
name: skill-delete
description: Remove a skill from the jsc skill set safely. Pick the skill from the Gitea canonical marketplace skill list, inventory every file referencing it, fix each affected file through decision-tree questions until guideline checks pass, delete the skill and verify no on-disk leftover in any CLI, then open a PR via jsc-git pr. Use only for removal; not for renaming (use skill-update).
description: Remove a skill from the jsc skill set safely. Pick the skill from the Gitea canonical marketplace skill list, inventory every file referencing it, fix each affected file through decision-tree questions until guideline checks pass, delete the skill and verify no on-disk leftover in any CLI, open a PR via jsc-git pr, then deploy the deletion into the current session and append the change report to wiki SKILLSET_{HASH}. Use only for removal; not for renaming (use skill-update).
---
# skill-delete — delete a skill
@@ -28,3 +28,9 @@ Single source of guidelines: [`../../references/guidelines.md`](../../references
Completion condition: the script exits 0, or exit 3 is reported to the user and recorded in the PR.
8. Call `jsc-git:pr` to open a Push Request. Completion condition: a PR URL comes back.
9. Apply the deletion to the current working session, verify it took, then report:
1. Force the change into the session — which of the two routes applies depends on where the change has reached, because the marketplace and `version-guard.sh` both read the repository's **default branch** (`master`), so `jsc-cli:deploy` cannot see anything that stopped at `develop`:
- The PR is merged all the way to `master`: call `jsc-cli:deploy` in update mode so every installed CLI loads the version without the skill, and restart the CLI when it asks (the deploy writes `$JSC_HOME/restart-required`; see guidelines.md「部署後重啟閘門」). When the deploy cannot update a CLI, record which CLIs did load the new version and carry on with one of those; when none did, stop and report the deletion as unverified. Completion condition: `claude plugin list` (or the equivalent command of another installed CLI) prints `jsc-{domain}` at the version the three manifests now carry.
- The PR is still short of `master` (waiting on review, or merged only into `develop`): deploying is pointless and its completion condition is unreachable, so verify against the **worktree** instead — run the next sub-step against `/root/plugins/{domain}` rather than the installed copy, mark the report as 「工作樹驗證、尚未部署」, and say plainly which release PR still has to merge before the deletion reaches any CLI. Until it merges the skill is still installed and still callable, so say that too. Completion condition: the verification sub-step passed against the worktree and the outstanding release PR is named in the report.
2. Verify the function concretely: run `tools/list-skills.sh` and confirm no row carries the deleted `{domain}/{name}`, rerun `tools/verify-skill-removed.sh {domain} {name}` for exit 0, then run every tool and skill that step 5 fixed and confirm each still finishes with its documented exit code — a fix that broke a caller shows up here, not earlier. On any mismatch — the deleted skill still listed, a leftover from exit 1, a fixed caller that now fails — fix the cause and rerun this step from 9.1. Completion condition: the skill is absent from the list, the verification script exits 0 (or its exit 3 stays reported as「無處可查」), and every fixed caller ran.
3. Write the change report to wiki page `SKILLSET_{HASH}` — this part MUST run as a sub agent. Call `jsc-gitea:wiki`; `{HASH}` comes from the `{owner}/{repo}` of the domain repo that lost the skill, and the wiki repo resolves through `JSC_WIKI_REPO_SKILLSET` first, then `JSC_WIKI_REPO`. **Append** a section for this change — date, 「刪除」, skill name, changed files (the step 5 inventory verdicts included), PR URL, the step 9.2 verification result per item — and keep every earlier section. Add the page to `SKILLSET_CONTENTS` when it is new. When the write fails — no `{owner}/{repo}` resolves, or `jsc-gitea:wiki` reports an API error — hand the page name and the unwritten entry back to the user and leave this step open; never close the flow on an unwritten report. Completion condition: the page holds the new section plus all earlier sections, and `SKILLSET_CONTENTS` links it.