chore(ai-review): 更新 findings.json 與 exclusions.json
CI / AI Code Review (pull_request) Failing after 32s
CI / AI Code Review (pull_request) Failing after 32s
移除本輪已具測試覆蓋的 finding(MAX_PAGES 邊界、刪除失敗記錄)與多項 先前已修復卻被重複提報者;保留 6 條設計取捨類待人工評估;新增 2 條不適用 (_getHeaders 過度設計、排序中間陣列與前次優化衝突)至 exclusions。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
fd2dfa8732
commit
b57180153e
@@ -58,5 +58,17 @@
|
||||
"role": "Leo",
|
||||
"original_finding": "categorizeTags 內部頻繁轉換 Set,若被頻繁呼叫可能造成效能浪費,建議改為接收已轉好的 Set。",
|
||||
"reason": "不適用。categorizeTags 每次清理流程僅被呼叫一次,單次建立 Set 成本可忽略;讓純函式自行建立 Set 可保持介面單純,將轉換責任外推反而增加耦合。"
|
||||
},
|
||||
{
|
||||
"location": "app/gitea-client.js:25",
|
||||
"role": "Bard",
|
||||
"original_finding": "GiteaClient 建構子的 header 初始化結構死板,建議抽離為內部 private 函式 _getHeaders() 以增加未來彈性。",
|
||||
"reason": "YAGNI / 不適用。目前僅單一固定標頭,建構子直接設定清楚直觀;為尚不存在的需求預先抽象屬過度設計,待真有多標頭需求時再重構。"
|
||||
},
|
||||
{
|
||||
"location": "app/releases.js:23",
|
||||
"role": "Rogue",
|
||||
"original_finding": "為排序而 map 成物件陣列再 map 回原物件,造成多次 O(n) 陣列分配與 GC 壓力,建議減少中間狀態或原地排序。",
|
||||
"reason": "不採納且與前次建議衝突。此 map/sort/map(Schwartzian transform)正是前一輪 Rogue(releases.js:17)要求「排序前預先計算時間戳」的實作,用以避免比較器重複呼叫 Date.parse;release 數量有限,中間陣列開銷可忽略,可讀性更佳。"
|
||||
}
|
||||
]
|
||||
|
||||
Reference in New Issue
Block a user