[ { "level": "critical", "role": "Maya", "location": "app/index.js:1, 14, 52, 58", "problem": "核心邏輯缺乏自動化測試。包含 main 入口點、自動解衝突流程、以及 `createPull` 錯誤處理與 fallback 機制均未受測試驗證,難以保證建置與合併的正確性。", "suggestion": "建立完整的單元與整合測試架構。Mock `Git`、`GiteaClient` 與 `OpenCode` 類別,針對 main() 覆蓋成功路徑與合併衝突的失敗路徑,並增強對 API 回傳錯誤的解析與處理。" }, { "level": "critical", "role": "Maya/Mage", "location": "app/lib/git.js:93, 106", "problem": "Git 衝突偵測與狀態復原邏輯缺乏測試。`detectConflict` 若行為預期外或 abort 失敗,將導致工作區殘留錯誤狀態,且未經測試驗證。", "suggestion": "針對 `Git.detectConflict` 補寫單元測試(模擬衝突場景)。在 `finally` 區塊中,增加檢查分支是否存在再進行刪除,確保環境乾淨。" }, { "level": "warning", "role": "Maya", "location": "app/index.js:114, 126, 154", "problem": "diff 截斷邏輯、fallbackSummary 邊界處理、以及分支名稱長度限制(Magic Number 180)缺乏測試或硬編碼,難以維護。", "suggestion": "補上針對 truncateDiff 及 commitMessages 為空/null 時的測試案例。將長度限制抽離為具名常數(例如 `MAX_BRANCH_NAME_LENGTH`)。" }, { "level": "warning", "role": "Assassin", "location": "Dockerfile:11", "problem": "Dockerfile 中使用全域 `npm install` 存在供應鏈風險。", "suggestion": "使用 lockfile(如 `package-lock.json`)確保依賴版本一致性,並定期審查更新。" }, { "level": "warning", "role": "Bard", "location": "app/lib/opencode.js:154", "problem": "錯誤訊息處理中,對 `result.stderr` 進行截斷,可能導致切斷關鍵錯誤上下文,除錯困難。", "suggestion": "改用 log.warn 輸出完整內容(遮蔽敏感資訊後),或將截斷訊息與「內容已截斷」提示並列。" }, { "level": "warning", "role": "Bard", "location": "app/index.js:80", "problem": "分支命名格式若目標分支名稱過長,可能導致總長度超過 Git 限制。", "suggestion": "調整 `stem` 截斷長度,或加入總長度檢查機制,確保不超過 255 字元。" }, { "level": "warning", "role": "Mage", "location": "app/index.js:52", "problem": "opencode 失敗時,若相關資訊皆為空,fallback 機制產出的 PR 描述將空洞無效。", "suggestion": "增加對 `fallbackSummary` 輸出內容的檢查。若資訊不足,應拋出錯誤或提供更有意義的預設說明。" }, { "level": "warning", "role": "Maya", "location": "app/lib/opencode.js:130, app/lib/gitea.js:56", "problem": "fallback 機制與 Gitea API 狀態碼處理(422/409)缺乏測試,難以確保產出品質與正確行為。", "suggestion": "補寫 OpenCode.summarize 與 GiteaClient.createPull 測試,Mock 不同情境回應,驗證系統邏輯。" }, { "level": "info", "role": "Maya", "location": "app/lib/opencode.js:176", "problem": "缺乏單元測試驗證 `extractResult` 對非標準 JSON 的解析能力。", "suggestion": "補上單元測試,驗證 extractResult 能否正確解析壞 JSON。", "is_new": false }, { "level": "info", "role": "Bard", "location": "app/lib/util.js:11, 13", "problem": "Buffer 大小硬編碼,缺乏靈活性,且針對極端巨大輸入缺乏保護。", "suggestion": "將 buffer 大小作為常數定義或透過環境變數傳入,並在呼叫 `run` 前增加對輸入內容的檢查。" }, { "level": "info", "role": "Bard", "location": "app/index.js:176", "problem": "PR 已存在時僅記錄 `log.info`,CI 流程中可能需要更明確的提示。", "suggestion": "建議改用 `log.warn` 或新增 `log.notice` 等級,以更明確提示使用者「PR 已經存在」。" }, { "level": "info", "role": "Leo", "location": "app/lib/git.js:32", "problem": "Sensitive Token 處理耦合在 `Git` 類別中,且未驗證有效性。", "suggestion": "將 Token 的遮蔽邏輯交由 `util.js` 處理,或在 `Git` 初始化時驗證其有效性。" } ]