chore(ai-review 狀態): 移除已處理 findings
CI / 輸出結果 (pull_request) Successful in 12s
CI / 計算版本號 (pull_request) Successful in 3s
CI / 工具測試 (pull_request) Successful in 1m33s
AI / Code Review (pull_request) Successful in 2m11s

This commit is contained in:
2026-06-24 13:09:36 +00:00
parent a01dbe5e2c
commit 770091828e
2 changed files with 19 additions and 83 deletions
+18
View File
@@ -64,5 +64,23 @@
"role": "Maya",
"original_finding": "應在測試案例中模擬空 MODEL 輸入,並驗證腳本是否正確拋出錯誤並以 exit 1 終止。",
"reason": "AI 對話收斂判定為誤報(問題在最新程式碼中不成立或不適用)"
},
{
"location": "Dockerfile:17",
"role": "Bard",
"original_finding": "將安裝腳本邏輯直接寫在 `RUN` 指令中顯得冗長,且使用 `$(mktemp)` 容易產生難以追蹤的臨時檔案。",
"reason": "安裝流程需在同一 Docker layer 中下載、驗證 SHA-256、執行並清理暫存腳本;留在 Dockerfile 可讓供應鏈驗證步驟與安裝命令緊鄰,mktemp 產生的檔案也已於同一 RUN 中刪除。"
},
{
"location": "entrypoint.sh:45",
"role": "Bard",
"original_finding": "使用靜態路徑檢查 `auth.json` 是否存在,若前次執行中斷導致檔案未清除,會導致後續執行失敗(Self-inflicted DoS)。",
"reason": "拒絕覆寫既有 auth.json 是刻意的 secret 安全保護,避免覆蓋呼叫端掛載或殘留的認證檔;Docker Action 預期每次執行使用獨立容器,前次中斷造成殘留的風險低於靜默覆寫 secret 的風險。"
},
{
"location": "tests/entrypoint_test.sh:17",
"role": "Bard",
"original_finding": "在測試中建立 `codex` 指令時,Here-document 與命令混雜,可讀性較低。",
"reason": "測試 helper 需要動態產生可執行的假 codex 指令,here-document 在此處比額外 fixture 檔更直觀且維持測試自含;此項屬風格偏好,不影響行為正確性。"
}
]