From 1ff74297ce08cca28ca7d893273707a16982ff78 Mon Sep 17 00:00:00 2001 From: Jeffery Date: Tue, 23 Jun 2026 16:36:25 +0800 Subject: [PATCH] =?UTF-8?q?chore(ai-review=20=E7=8B=80=E6=85=8B):=20?= =?UTF-8?q?=E8=A3=9C=20NaN=20=E6=B8=AC=E8=A9=A6=E3=80=81=E6=8E=92=E9=99=A4?= =?UTF-8?q?=20recordRateLimit=20=E5=BE=AE=E5=84=AA=E5=8C=96=E8=AA=A4?= =?UTF-8?q?=E5=A0=B1=EF=BC=8C=E6=B8=85=E7=A9=BA=20findings.json?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .gitea/ai-review/exclusions.json | 6 ++++++ .gitea/ai-review/findings.json | 19 +------------------ 2 files changed, 7 insertions(+), 18 deletions(-) diff --git a/.gitea/ai-review/exclusions.json b/.gitea/ai-review/exclusions.json index 6a36245..0c8f679 100644 --- a/.gitea/ai-review/exclusions.json +++ b/.gitea/ai-review/exclusions.json @@ -518,5 +518,11 @@ "role": "Maya", "original_finding": "parseBotReviewComment 的測試沒有驗證解析失敗時回傳 null 的行為。", "reason": "誤判,測試已存在。'returns null for free-form human comments' 已斷言自由格式留言、空字串、null 皆回傳 null。" + }, + { + "location": "app/usage.js:146", + "role": "Rogue", + "original_finding": "在 recordRateLimit 中頻繁呼叫 lowerCaseKeys,對每個請求的 headers 複製與轉換,增加記憶體分配開銷;建議改用不分大小寫存取避免複製。", + "reason": "過度設計/非熱路徑。recordRateLimit 每次 LLM 回應只呼叫一次(一輪審查約 13 次),headers 物件小,複製成本可忽略;改用不分大小寫存取器反而增加複雜度,效益不成比例。" } ] diff --git a/.gitea/ai-review/findings.json b/.gitea/ai-review/findings.json index bd73ac7..fe51488 100644 --- a/.gitea/ai-review/findings.json +++ b/.gitea/ai-review/findings.json @@ -1,18 +1 @@ -[ - { - "level": "warning", - "role": "Maya", - "location": "app/usage.test.js:240", - "problem": "`formatUsageStatsLine` 測試案例中,僅驗證了單一平台的格式,缺失了當 `quota` 或 `rate` 資料缺失或包含無效數字(如 `NaN`)時的處理測試。", - "suggestion": "補充針對 `quota` 或 `rate` 傳入異常資料(如 `limit: NaN`)的測試,驗證 `formatUsageStatsLine` 是否能產生安全的預設文字,而非輸出 `NaN` 或破壞版面。", - "is_new": true - }, - { - "level": "warning", - "role": "Rogue", - "location": "app/usage.js:146", - "problem": "在 `recordRateLimit` 中頻繁呼叫 `lowerCaseKeys`,這會對每個請求的 headers 進行複製與轉換,增加記憶體分配開銷。", - "suggestion": "建議直接存取 headers 時改用不區分大小寫的存取函式,避免複製整個物件。", - "is_new": true - } -] +[]