40 lines
2.1 KiB
JSON
40 lines
2.1 KiB
JSON
{
|
|
"generatedAt": "2026/07/20 18:00:02",
|
|
"commitSha": "d354f30c270e99baa9dcfc6aa76510710c0193ca",
|
|
"prNumber": null,
|
|
"tool": {
|
|
"name": "code-review-resolve",
|
|
"version": "0.0.8",
|
|
"model": "（工具預設）"
|
|
},
|
|
"findings": [
|
|
{
|
|
"id": "F001",
|
|
"reviewer": "🧰 Leo",
|
|
"focus": "maintainability",
|
|
"badge": "🧰",
|
|
"severity": "警告",
|
|
"file": "src/index.js",
|
|
"startLine": 257,
|
|
"endLine": 307,
|
|
"problem": "流程步驟編號同時硬編碼在 log 字串、區段註解、JSDoc、README 與多個函式庫中。插入或調整一個步驟就必須跨大量檔案全面改號，容易讓文件與實際紀錄不一致。",
|
|
"suggestion": "程式內改用穩定的語意階段名稱（如 diff、attack、defend、publish），由單一流程定義集中決定顯示順序；JSDoc 以階段名稱互相引用，README 流程圖由同一份階段資料產生或僅在文件層維護展示編號。",
|
|
"suggestedCode": "const PHASE = Object.freeze({\n RESOLVE_OLD: '清理舊留言',\n DETECT_TOOL: '偵測工具',\n COLLECT_DIFF: '整理差異',\n ATTACK: '攻擊方審查',\n DEFEND: '防守方裁決',\n});\n\nlog(PHASE.COLLECT_DIFF, 'INF', `變更檔案 ${allFiles.length} 個…`);"
|
|
},
|
|
{
|
|
"id": "F002",
|
|
"reviewer": "🧪 Maya",
|
|
"focus": "testing",
|
|
"badge": "🧪",
|
|
"severity": "警告",
|
|
"file": "src/lib/gitrepo.js",
|
|
"startLine": 252,
|
|
"endLine": 289,
|
|
"problem": "commitAndPushFindings 的推送行為（有無變更、認證方式、空 commit 防護、是否觸發 CI）缺少測試證明。此為本次變更的核心行為，卻沒有任何測試覆蓋。",
|
|
"suggestion": "mock git 命令，斷言：無 staged diff 時回傳 false 且不執行 commit／push；有變更時以認證方式推送到正確 refspec 與分支。注意：原 finding 描述的 pushToken 對比 origin 雙軌邏輯已於重構後移除（現行一律以 token 經 pushWithCredential 認證推送），撰寫測試前需依現行程式碼重新界定情境。",
|
|
"suggestedCode": ""
|
|
}
|
|
],
|
|
"excluded": []
|
|
}
|