Compare commits
3 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| ee864dea13 | |||
| 15be1fea8a | |||
| 676bb74235 |
@@ -18,7 +18,7 @@ description: Triage findings, fix real issues, and exclude false positives.
|
|||||||
- info
|
- info
|
||||||
3. Renumber from 1.
|
3. Renumber from 1.
|
||||||
4. Fix real issues.
|
4. Fix real issues.
|
||||||
5. Put false positives into `.gitea/ai-review/exclusions.json`, preserving the original wording, language, and semantics as much as possible.
|
5. Put false positives into `.gitea/ai-review/exclusions.json` as a top-level JSON array, preserving the original wording, language, and semantics as much as possible. Do not wrap the array in `exclusions` or `excluded_findings`.
|
||||||
6. Add tests when behavior changes.
|
6. Add tests when behavior changes.
|
||||||
|
|
||||||
## Output Rules
|
## Output Rules
|
||||||
@@ -26,4 +26,5 @@ description: Triage findings, fix real issues, and exclude false positives.
|
|||||||
- Keep the final list short.
|
- Keep the final list short.
|
||||||
- Keep numbering contiguous.
|
- Keep numbering contiguous.
|
||||||
- Preserve file path, location, and fix.
|
- Preserve file path, location, and fix.
|
||||||
|
- When writing exclusions, always output a top-level JSON array.
|
||||||
- When writing exclusions, prefer the original issue text over paraphrased rewrites.
|
- When writing exclusions, prefer the original issue text over paraphrased rewrites.
|
||||||
|
|||||||
@@ -21,7 +21,7 @@ It is also used when some findings are false positives and should be moved into
|
|||||||
4. Renumber the sorted list from 1 upward.
|
4. Renumber the sorted list from 1 upward.
|
||||||
5. Rewrite each finding concisely so the final list reads cleanly and consistently.
|
5. Rewrite each finding concisely so the final list reads cleanly and consistently.
|
||||||
6. If a finding is a false positive, do not keep it in the final list.
|
6. If a finding is a false positive, do not keep it in the final list.
|
||||||
7. Add false positives to the exclusions list using the existing schema in the repo or task context, and preserve the original finding wording as much as possible, including language and semantics.
|
7. Add false positives to the exclusions list as a top-level JSON array in `.gitea/ai-review/exclusions.json`, and preserve the original finding wording as much as possible, including language and semantics. Do not wrap the array in `exclusions` or `excluded_findings`.
|
||||||
|
|
||||||
## Resolution Flow
|
## Resolution Flow
|
||||||
|
|
||||||
@@ -41,5 +41,6 @@ After the list is merged and ordered, resolve the remaining findings one by one.
|
|||||||
- Keep numbering contiguous after filtering and merging.
|
- Keep numbering contiguous after filtering and merging.
|
||||||
- Preserve useful details like file path, location, and suggested fix.
|
- Preserve useful details like file path, location, and suggested fix.
|
||||||
- Keep exclusions entries minimal and consistent with the project schema.
|
- Keep exclusions entries minimal and consistent with the project schema.
|
||||||
|
- When writing exclusions, always output a top-level JSON array.
|
||||||
- When writing exclusions, prefer the original issue text and language; only paraphrase if needed to fit the schema.
|
- When writing exclusions, prefer the original issue text and language; only paraphrase if needed to fit the schema.
|
||||||
- If the source already provides a severity or title, keep it unless it conflicts with the final ordering.
|
- If the source already provides a severity or title, keep it unless it conflicts with the final ordering.
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
interface:
|
interface:
|
||||||
display_name: "Triage Findings"
|
display_name: "Triage Findings"
|
||||||
short_description: "Triage, sort, fix, and exclude review findings"
|
short_description: "Triage, sort, fix, and exclude review findings"
|
||||||
default_prompt: "Use $triage-findings to merge review findings, sort and renumber them by severity, resolve real issues one by one, and add false positives to exclusions."
|
default_prompt: "Use $triage-findings to merge review findings, sort and renumber them by severity, resolve real issues one by one, and add false positives to `.gitea/ai-review/exclusions.json` as a top-level JSON array."
|
||||||
|
|||||||
@@ -18,7 +18,7 @@ description: Triage findings, fix real issues, and exclude false positives.
|
|||||||
- info
|
- info
|
||||||
3. Renumber from 1.
|
3. Renumber from 1.
|
||||||
4. Fix real issues.
|
4. Fix real issues.
|
||||||
5. Put false positives into `.gitea/ai-review/exclusions.json`, preserving the original wording, language, and semantics as much as possible.
|
5. Put false positives into `.gitea/ai-review/exclusions.json` as a top-level JSON array, preserving the original wording, language, and semantics as much as possible. Do not wrap the array in `exclusions` or `excluded_findings`.
|
||||||
6. Add tests when behavior changes.
|
6. Add tests when behavior changes.
|
||||||
|
|
||||||
## Output Rules
|
## Output Rules
|
||||||
@@ -26,4 +26,5 @@ description: Triage findings, fix real issues, and exclude false positives.
|
|||||||
- Keep the final list short.
|
- Keep the final list short.
|
||||||
- Keep numbering contiguous.
|
- Keep numbering contiguous.
|
||||||
- Preserve file path, location, and fix.
|
- Preserve file path, location, and fix.
|
||||||
|
- When writing exclusions, always output a top-level JSON array.
|
||||||
- When writing exclusions, prefer the original issue text over paraphrased rewrites.
|
- When writing exclusions, prefer the original issue text over paraphrased rewrites.
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ Use the triage-finding workflow for review issue lists:
|
|||||||
3. Sort by severity: `critical` -> `warning` -> `info`.
|
3. Sort by severity: `critical` -> `warning` -> `info`.
|
||||||
4. Renumber from 1.
|
4. Renumber from 1.
|
||||||
5. Fix real issues with the smallest safe change.
|
5. Fix real issues with the smallest safe change.
|
||||||
6. Put false positives into `.gitea/ai-review/exclusions.json`, preserving the original wording, language, and semantics as much as possible.
|
6. Put false positives into `.gitea/ai-review/exclusions.json` as a top-level JSON array, preserving the original wording, language, and semantics as much as possible. Do not wrap the array in `exclusions` or `excluded_findings`.
|
||||||
7. Add or update tests when behavior changes.
|
7. Add or update tests when behavior changes.
|
||||||
8. Re-check after each fix.
|
8. Re-check after each fix.
|
||||||
|
|
||||||
|
|||||||
+1
-1
@@ -1,7 +1,7 @@
|
|||||||
FROM ubuntu:24.04
|
FROM ubuntu:24.04
|
||||||
|
|
||||||
RUN apt-get update \
|
RUN apt-get update \
|
||||||
&& apt-get install -y --no-install-recommends curl \
|
&& apt-get install -y --no-install-recommends curl ca-certificates \
|
||||||
&& rm -rf /var/lib/apt/lists/*
|
&& rm -rf /var/lib/apt/lists/*
|
||||||
|
|
||||||
COPY rootCA.pem /usr/local/share/ca-certificates/rootCA.crt
|
COPY rootCA.pem /usr/local/share/ca-certificates/rootCA.crt
|
||||||
|
|||||||
Reference in New Issue
Block a user