Compare commits
29 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 41a8fe100f | |||
| c1c00449af | |||
| ef3654b091 | |||
| 5d0c9fd691 | |||
| 5860588588 | |||
| 53a7ec7a3e | |||
| 42241c5000 | |||
| 1a12ec4e2e | |||
| a90886e924 | |||
| 57285ce145 | |||
| 0aefa66224 | |||
| 66d93abe24 | |||
| 0063f3282f | |||
| 8c3d0d9a6d | |||
| 3849bb2168 | |||
| 379938d6dc | |||
| 5bf39966d0 | |||
| 3509a882e1 | |||
| 1d2e8236de | |||
| d8423c74b1 | |||
| 94e974b5dc | |||
| a9a0b43ea5 | |||
| aa8234b5c7 | |||
| b0f2d45c11 | |||
| 3fd9a7e13d | |||
| 39cc5c932c | |||
| 255adbabe4 | |||
| a10fc8f176 | |||
| 9b39908394 |
@@ -3,29 +3,5 @@
|
|||||||
"role": "Rex",
|
"role": "Rex",
|
||||||
"location": "app/git.js",
|
"location": "app/git.js",
|
||||||
"suggestion": "請避免將敏感資料(如 GITEA_TOKEN)直接寫入環境變數"
|
"suggestion": "請避免將敏感資料(如 GITEA_TOKEN)直接寫入環境變數"
|
||||||
},
|
|
||||||
{
|
|
||||||
"location": "app/git.js",
|
|
||||||
"suggestion": "GITEA_TOKEN 直接嵌入 URL 中"
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"role": "Rex",
|
|
||||||
"location": "README.md",
|
|
||||||
"suggestion": "contents: write、pull-requests: write、issues: write 為此 Action 正常運作所必要的權限"
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"role": "Leo",
|
|
||||||
"location": "app/config.js",
|
|
||||||
"suggestion": "getLLMConfig 在找不到任何符合條件的 provider 時會回傳 undefined"
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"role": "Rex",
|
|
||||||
"location": ".gitea/ai-review/exclusions.json",
|
|
||||||
"suggestion": "GITEA_TOKEN 直接嵌入 URL 的做法"
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"role": "Aria",
|
|
||||||
"location": ".gitea/ai-review/exclusions.json",
|
|
||||||
"suggestion": "role 欄位會導致驗證失敗"
|
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
|
|||||||
@@ -1,142 +1,142 @@
|
|||||||
[
|
[
|
||||||
{
|
{
|
||||||
"level": "critical",
|
"level": "warning",
|
||||||
"role": "Leo",
|
"role": "Leo",
|
||||||
"location": "app/config.js:1",
|
"location": "app/findings.js:93",
|
||||||
"suggestion": "`getLLMConfig` 在找不到任何符合條件的 provider 時會回傳 `undefined`,而呼叫端(例如測試)假設會得到一個包含 `provider`、`apiKey`、`baseURL`、`model` 欄位的物件,導致執行時拋出 `TypeError`。請在函式結尾加入預設回傳值,例如 `return { provider: null, apiKey: null, baseURL: null, model: null };`,並在文件中說明此行為。",
|
"suggestion": "建議在 loadExclusions 函式中增加對於 JSON 格式的驗證,確保讀取的資料符合預期格式,避免潛在的錯誤。",
|
||||||
"is_new": true
|
"is_new": true
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"level": "critical",
|
"level": "warning",
|
||||||
|
"role": "Leo",
|
||||||
|
"location": "app/findings.js:40",
|
||||||
|
"suggestion": "在 applyExclusions 函式中,建議增加對於 findings 和 exclusions 參數的有效性檢查,以提高程式的健壯性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "warning",
|
||||||
|
"role": "Zara",
|
||||||
|
"location": "app/findings.js:40",
|
||||||
|
"suggestion": "在 applyExclusions 函數中,使用 Array.prototype.some 進行過濾時,可能會導致性能問題,特別是當 findings 和 exclusions 的數量都很大時。建議使用更高效的資料結構(如 HashSet)來加速查詢。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "warning",
|
||||||
"role": "Rex",
|
"role": "Rex",
|
||||||
"location": ".gitea/ai-review/exclusions.json:7",
|
|
||||||
"suggestion": "請移除 GITEA_TOKEN 直接嵌入 URL 的做法,改以環境變數或 Gitea Secrets 注入,避免在程式碼或設定檔中硬編碼機密資訊。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "critical",
|
|
||||||
"role": "Aria",
|
|
||||||
"location": ".gitea/ai-review/exclusions.json",
|
"location": ".gitea/ai-review/exclusions.json",
|
||||||
"suggestion": "新增的條目包含 `role` 欄位,但目前的 JSON schema 只接受 `location` 與 `suggestion`,此欄位會導致驗證失敗,請移除或更新 schema。",
|
"suggestion": "請避免將敏感資料(如 GITEA_TOKEN)直接寫入環境變數",
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Leo",
|
|
||||||
"location": "app/config.js:5",
|
|
||||||
"suggestion": "目前使用硬編碼的 `checks` 陣列來管理所有 LLM provider,未來若要新增或移除 provider 必須直接修改程式碼,易產生重複與維護負擔。建議將 provider 設定抽離至外部 JSON/YAML 檔或使用可擴充的資料結構,並在程式中載入,提升模組化與可維護性。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Leo",
|
|
||||||
"location": "app/config.js:3",
|
|
||||||
"suggestion": "為 `getLLMConfig` 加上 JSDoc 或 TypeScript 型別註解,說明回傳物件的結構與每個欄位的意義,方便其他開發者快速了解 API,降低錯誤使用的風險。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Zara",
|
|
||||||
"location": "app/config.js",
|
|
||||||
"suggestion": "將 getLLMConfig 的結果快取(例如使用單例或 memoization),避免在程式執行期間多次重複遍歷 checks 陣列與讀取 process.env,減少不必要的 I/O 開銷。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Rex",
|
|
||||||
"location": ".gitea/workflows/review.yaml:33",
|
|
||||||
"suggestion": "工作流程目前授予 contents、pull‑requests、issues 三項 write 權限,過於寬鬆。建議依實際需求僅授予 read 或最小必要的 write 權限,以降低被濫用的風險。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Rex",
|
|
||||||
"location": ".gitea/workflows/review.yaml:35",
|
|
||||||
"suggestion": "將 OPENAI_API_KEY 參數改為使用正確的 secret 名稱(如 OPENROUTER_API_KEY)時,請確保工作流程文件中不會同時暴露兩個不同的 secret 名稱,以免因名稱錯誤導致金鑰未傳入或意外洩漏。",
|
|
||||||
"is_new": true
|
"is_new": true
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"level": "warning",
|
"level": "warning",
|
||||||
"role": "Aria",
|
"role": "Aria",
|
||||||
"location": ".gitea/workflows/review.yaml:33",
|
"location": "README.md:4",
|
||||||
"suggestion": "在 `OPENAI_API_KEY` 後的註解前應保留一個空格,以符合常見的 YAML 註解風格:`... ${{ secrets.OPENROUTER_API_KEY }} # OpenRouter 使用 OpenAI 相容介面,以 OPENAI_API_KEY 傳入`。",
|
"suggestion": "建議將「讀取排除問題檔案,用來過濾PR問題表格中不需要處理的問題」的描述改為「讀取排除問題檔案,過濾 PR 問題表格中不需要處理的問題」,以保持一致性。",
|
||||||
"is_new": true
|
"is_new": true
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"level": "warning",
|
"level": "warning",
|
||||||
"role": "Aria",
|
"role": "Maya",
|
||||||
|
"location": "app/findings.js:40",
|
||||||
|
"suggestion": "建議在 applyExclusions 函數中增加對 findings 內容的驗證,確保其格式正確,以提高測試的穩定性和可靠性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Leo",
|
||||||
"location": "README.md",
|
"location": "README.md",
|
||||||
"suggestion": "文件中章節編號不連續(例如 `### 2. OpenRouter` 後直接跳到 `### 3. Anthropic Claude`),建議重新編號或使用一致的標題層級,以提升可讀性與維護性。",
|
"suggestion": "建議在 README 中增加對於新功能(如排除問題過濾)的詳細說明,以便未來的維護者能快速了解其功能。",
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Aria",
|
|
||||||
"location": "app/config.js",
|
|
||||||
"suggestion": "`checks` 陣列的每一行過長,超過 120 個字元,建議拆成多行並對齊欄位,以符合程式碼可讀性與行長限制的慣例。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Aria",
|
|
||||||
"location": "app/config.js",
|
|
||||||
"suggestion": "`amazonq` 那一行的空格對齊與其他項目不一致,請統一使用單一個空格分隔欄位,或使用對齊工具保持列的垂直對齊。",
|
|
||||||
"is_new": true
|
"is_new": true
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"level": "info",
|
"level": "info",
|
||||||
"role": "Leo",
|
"role": "Leo",
|
||||||
"location": "app/findings.js:150",
|
"location": "app/main.js",
|
||||||
"suggestion": "在 `filterFalsePositivesWithAI` 中,當 AI 回傳空陣列時拋出錯誤,可能導致上層流程中斷。建議改為回傳原始 `findings` 或提供更具體的錯誤類別,並在文件中說明此行為,以提升錯誤處理的可預測性。",
|
"suggestion": "建議在 main 函式中增加對於每個步驟的詳細註解,讓未來的維護者能更容易理解程式邏輯。",
|
||||||
"is_new": true
|
"is_new": true
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"level": "info",
|
"level": "info",
|
||||||
"role": "Zara",
|
"role": "Zara",
|
||||||
"location": "app/findings.js",
|
"location": "app/findings.js:39",
|
||||||
"suggestion": "在 filterFalsePositivesWithAI 中,若 AI 回傳的陣列非常大,建議在回傳前加入分頁或限制筆數,避免一次性載入過多資料導致記憶體使用量激增。",
|
"suggestion": "在過濾 findings 時,建議將過濾條件的邏輯提取為獨立函數,以提高可讀性和可維護性。",
|
||||||
"is_new": true
|
"is_new": true
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"level": "info",
|
"level": "info",
|
||||||
"role": "Zara",
|
"role": "Zara",
|
||||||
|
"location": "app/main.js:64",
|
||||||
|
"suggestion": "在讀取排除問題檔案時,建議考慮使用非同步方法(如 fs.promises.readFile)來避免阻塞事件循環,提升效能。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Aria",
|
||||||
|
"location": "README.md:8",
|
||||||
|
"suggestion": "建議將「如果PR問題表格中有嚴重問題,則不要讓 workflow 執行成功(exit 1)」的描述改為「如果 PR 問題表格中有嚴重問題,則不要讓 workflow 執行成功(exit 1)」以提高可讀性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Aria",
|
||||||
|
"location": "TODO.md:4",
|
||||||
|
"suggestion": "建議將「階段四:findings 寫入與 comment 發布」的標題改為「階段四:排除問題過濾」,以更清楚地反映內容。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Aria",
|
||||||
|
"location": "TODO.md:6",
|
||||||
|
"suggestion": "建議將「階段五:findings 寫入與 comment 發布」的標題改為「階段五:findings 寫入與 comment 發布」,以保持一致性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Aria",
|
||||||
|
"location": "TODO.md:8",
|
||||||
|
"suggestion": "建議將「階段六:記憶區 commit/push 與錯誤處理」的標題改為「階段六:記憶區 commit/push 與錯誤處理」,以保持一致性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Aria",
|
||||||
|
"location": "TODO.md:10",
|
||||||
|
"suggestion": "建議將「階段七:阻擋嚴重問題 PR(第 8 點)」的標題改為「階段七:阻擋嚴重問題 PR(第 8 點)」以保持一致性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Aria",
|
||||||
"location": "app/config.js",
|
"location": "app/config.js",
|
||||||
"suggestion": "對於未設定 API 金鑰的 provider(如 ollama),可提前返回快取的預設設定,避免每次呼叫都進行條件檢查。",
|
"suggestion": "建議在 EXCLUSIONS_PATH 的定義上方添加註解,說明該常數的用途,以提高可讀性。",
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "info",
|
|
||||||
"role": "Rex",
|
|
||||||
"location": "README.md:28",
|
|
||||||
"suggestion": "文件中列出的權限說明應與實際 workflow 中的 permissions 保持一致,並提醒使用者僅在必要時授予 write 權限,避免在 CI/CD 環境中過度授權。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "info",
|
|
||||||
"role": "Rex",
|
|
||||||
"location": "app/config.js:12",
|
|
||||||
"suggestion": "在取得 LLM 設定時,若 key 為空字串仍會被視為有效。建議在判斷前先檢查 key 是否為非空字串,以防止意外使用空的 API 金鑰發送請求。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "info",
|
|
||||||
"role": "Aria",
|
|
||||||
"location": "app/config.test.js",
|
|
||||||
"suggestion": "匯入語句過長,建議改寫為多行匯入,例如:\n```js\nimport {\n describe,\n it,\n beforeEach,\n afterEach\n} from 'node:test';\n```",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "info",
|
|
||||||
"role": "Aria",
|
|
||||||
"location": "app/config.test.js",
|
|
||||||
"suggestion": "`ENV_KEYS` 陣列過長,建議分行列舉,每行放置一個環境變數,以提升可讀性。",
|
|
||||||
"is_new": true
|
"is_new": true
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"level": "info",
|
"level": "info",
|
||||||
"role": "Aria",
|
"role": "Aria",
|
||||||
"location": "app/findings.js",
|
"location": "app/findings.js",
|
||||||
"suggestion": "錯誤訊息 `AI 回傳空陣列或非陣列` 可簡化為 `AI 回傳的結果不是有效的非空陣列`,讓訊息更清晰。",
|
"suggestion": "建議在 loadExclusions 函數的開頭添加註解,說明該函數的用途,以提高可讀性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Aria",
|
||||||
|
"location": "app/findings.js",
|
||||||
|
"suggestion": "建議在 applyExclusions 函數的開頭添加註解,說明該函數的用途,以提高可讀性。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Maya",
|
||||||
|
"location": "app/findings.js:7",
|
||||||
|
"suggestion": "建議為 loadExclusions 和 applyExclusions 函數撰寫單元測試,以確保其功能正確並能處理邊界條件。",
|
||||||
|
"is_new": true
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"level": "info",
|
||||||
|
"role": "Maya",
|
||||||
|
"location": "app/main.js:48",
|
||||||
|
"suggestion": "建議在每個主要步驟之後增加測試用例,以驗證每個步驟的輸出是否符合預期。",
|
||||||
"is_new": true
|
"is_new": true
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
@@ -33,9 +33,8 @@ jobs:
|
|||||||
- name: AI Code Review
|
- name: AI Code Review
|
||||||
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@v${{ needs.version.outputs.version }}
|
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@v${{ needs.version.outputs.version }}
|
||||||
with:
|
with:
|
||||||
OPENAI_API_KEY: ${{ secrets.OPENROUTER_API_KEY }} # OpenRouter 使用 OpenAI 相容介面,以 OPENAI_API_KEY 傳入
|
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
|
||||||
OPENAI_BASE_URL: https://openrouter.ai/api/v1
|
OPENAI_BASE_URL: https://openrouter.ai/api/v1
|
||||||
OPENAI_MODEL: ${{ vars.OPENROUTER_MODEL }}
|
|
||||||
permissions:
|
permissions:
|
||||||
contents: write
|
contents: write
|
||||||
pull-requests: write
|
pull-requests: write
|
||||||
|
|||||||
@@ -6,8 +6,8 @@
|
|||||||
|
|
||||||
1. 服務名稱、模型名稱、角色資訊(個性、符合個性的英文名稱、工作內容),Comment 到 Push Request
|
1. 服務名稱、模型名稱、角色資訊(個性、符合個性的英文名稱、工作內容),Comment 到 Push Request
|
||||||
2. 每個角色個別分析 Git Diff 的內容產生新問題表格(問題等級、角色名稱、問題位置或行數、修改建議)
|
2. 每個角色個別分析 Git Diff 的內容產生新問題表格(問題等級、角色名稱、問題位置或行數、修改建議)
|
||||||
3. 讀取所有未解決的舊問題(問題檔案 `.gitea/ai-review/findings.json` 存在於使用此 Action 的專案固定位置)加上新問題後,去除重複產生本次 Push Request 的問題表格(PR問題表格)覆蓋問題檔案
|
3. 讀取所有未解決的舊問題(問題檔案存在於使用此 Action 的專案固定位置)加上新問題後,去除重複產生本次 Push Request 的問題表格(PR問題表格)覆蓋問題檔案
|
||||||
4. 讀取排除問題檔案(`.gitea/ai-review/exclusions.json` 存在於使用此 Action 的專案固定位置),用來過濾PR問題表格中不需要處理的問題
|
4. 讀取排除問題檔案,用來過濾PR問題表格中不需要處理的問題
|
||||||
5. 從PR問題表格中取出所有舊問題,依照等級排序後 Comment 到 Push Request
|
5. 從PR問題表格中取出所有舊問題,依照等級排序後 Comment 到 Push Request
|
||||||
6. 從PR問題表格中取出所有新問題,排除嚴重等級的問題後 Comment 到 Push Request
|
6. 從PR問題表格中取出所有新問題,排除嚴重等級的問題後 Comment 到 Push Request
|
||||||
7. 從PR問題表格中取出所有新問題,將每個嚴重等級的問題 Comment 到 Push Request
|
7. 從PR問題表格中取出所有新問題,將每個嚴重等級的問題 Comment 到 Push Request
|
||||||
@@ -28,7 +28,7 @@
|
|||||||
2. 在 `.gitea/workflows` 資料夾中建立 `ai-review.yaml'
|
2. 在 `.gitea/workflows` 資料夾中建立 `ai-review.yaml'
|
||||||
3. 在 `ai-review.yaml` 中填入以下內容(選擇一個使用):
|
3. 在 `ai-review.yaml` 中填入以下內容(選擇一個使用):
|
||||||
|
|
||||||
### 1. OpenAI
|
### 1. OpenAI(OpenRouter)
|
||||||
```yaml
|
```yaml
|
||||||
name: AI
|
name: AI
|
||||||
on:
|
on:
|
||||||
@@ -42,39 +42,17 @@ jobs:
|
|||||||
- name: AI Code Review
|
- name: AI Code Review
|
||||||
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
|
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
|
||||||
with:
|
with:
|
||||||
|
# Github (h3285@evertrust.com.tw)
|
||||||
|
# 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
|
||||||
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
|
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
|
||||||
OPENAI_BASE_URL: https://api.openai.com/v1
|
|
||||||
OPENAI_MODEL: ${{ vars.OPENAI_MODEL }}
|
|
||||||
permissions:
|
|
||||||
contents: write
|
|
||||||
pull-requests: write
|
|
||||||
issues: write
|
|
||||||
```
|
|
||||||
|
|
||||||
### 2. OpenRouter
|
|
||||||
```yaml
|
|
||||||
name: AI
|
|
||||||
on:
|
|
||||||
pull_request:
|
|
||||||
types: [opened, synchronize]
|
|
||||||
jobs:
|
|
||||||
code-review:
|
|
||||||
name: 'Code Review'
|
|
||||||
runs-on: ubuntu
|
|
||||||
steps:
|
|
||||||
- name: AI Code Review
|
|
||||||
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
|
|
||||||
with:
|
|
||||||
OPENAI_API_KEY: ${{ secrets.OPENROUTER_API_KEY }} # OpenRouter 使用 OpenAI 相容介面,以 OPENAI_API_KEY 傳入
|
|
||||||
OPENAI_BASE_URL: https://openrouter.ai/api/v1
|
OPENAI_BASE_URL: https://openrouter.ai/api/v1
|
||||||
OPENAI_MODEL: ${{ vars.OPENROUTER_MODEL }}
|
|
||||||
permissions:
|
permissions:
|
||||||
contents: write
|
contents: write
|
||||||
pull-requests: write
|
pull-requests: write
|
||||||
issues: write
|
issues: write
|
||||||
```
|
```
|
||||||
|
|
||||||
### 3. Anthropic Claude
|
### 2. Anthropic Claude
|
||||||
```yaml
|
```yaml
|
||||||
name: AI
|
name: AI
|
||||||
on:
|
on:
|
||||||
@@ -96,7 +74,7 @@ jobs:
|
|||||||
issues: write
|
issues: write
|
||||||
```
|
```
|
||||||
|
|
||||||
### 4. Google Gemini
|
### 3. Google Gemini
|
||||||
```yaml
|
```yaml
|
||||||
name: AI
|
name: AI
|
||||||
on:
|
on:
|
||||||
@@ -112,14 +90,13 @@ jobs:
|
|||||||
with:
|
with:
|
||||||
GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }}
|
GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY }}
|
||||||
GEMINI_BASE_URL: https://generativelanguage.googleapis.com/v1beta
|
GEMINI_BASE_URL: https://generativelanguage.googleapis.com/v1beta
|
||||||
GEMINI_MODEL: ${{ vars.GEMINI_MODEL }}
|
|
||||||
permissions:
|
permissions:
|
||||||
contents: write
|
contents: write
|
||||||
pull-requests: write
|
pull-requests: write
|
||||||
issues: write
|
issues: write
|
||||||
```
|
```
|
||||||
|
|
||||||
### 5. Amazon Q
|
### 4. Amazon Q
|
||||||
```yaml
|
```yaml
|
||||||
name: AI
|
name: AI
|
||||||
on:
|
on:
|
||||||
@@ -141,6 +118,28 @@ jobs:
|
|||||||
issues: write
|
issues: write
|
||||||
```
|
```
|
||||||
|
|
||||||
|
### 5. SonarQube
|
||||||
|
```yaml
|
||||||
|
name: AI
|
||||||
|
on:
|
||||||
|
pull_request:
|
||||||
|
types: [opened, synchronize]
|
||||||
|
jobs:
|
||||||
|
code-review:
|
||||||
|
name: 'Code Review'
|
||||||
|
runs-on: ubuntu
|
||||||
|
steps:
|
||||||
|
- name: AI Code Review
|
||||||
|
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
|
||||||
|
with:
|
||||||
|
SONARQUBE_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
|
||||||
|
SONARQUBE_URL: https://sonarqube.example.com
|
||||||
|
permissions:
|
||||||
|
contents: write
|
||||||
|
pull-requests: write
|
||||||
|
issues: write
|
||||||
|
```
|
||||||
|
|
||||||
### - Ollama
|
### - Ollama
|
||||||
|
|
||||||
```yaml
|
```yaml
|
||||||
@@ -156,7 +155,7 @@ jobs:
|
|||||||
- name: AI Code Review
|
- name: AI Code Review
|
||||||
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
|
uses: https://gitea.jsc.idv.tw/jiantw83/code-review@${{ vars.ACTION_CODE_REVIEW_VERSION }}
|
||||||
with:
|
with:
|
||||||
OLLAMA_BASE_URL: https://ollama.jsc.idv.me/v1
|
OLLAMA_BASE_URL: ${{ vars.OLLAMA_BASE_URL }}
|
||||||
OLLAMA_MODEL: ${{ vars.OLLAMA_MODEL }}
|
OLLAMA_MODEL: ${{ vars.OLLAMA_MODEL }}
|
||||||
permissions:
|
permissions:
|
||||||
contents: write
|
contents: write
|
||||||
|
|||||||
@@ -15,14 +15,14 @@
|
|||||||
- 驗收:log 中能看到 deduplication/resolution confirmation 成功或失敗(如 402),降級時有「保留所有問題」等明確訊息。
|
- 驗收:log 中能看到 deduplication/resolution confirmation 成功或失敗(如 402),降級時有「保留所有問題」等明確訊息。
|
||||||
- 完成
|
- 完成
|
||||||
|
|
||||||
## 階段四:AI 排除問題過濾
|
## 階段四:排除問題過濾
|
||||||
- 目標:讀取排除問題檔案(`.gitea/ai-review/exclusions.json`)進行規則過濾,並呼叫 AI 判斷剩餘問題是否為誤報或不適用,兩層過濾後產生最終問題清單。
|
- 目標:讀取排除問題檔案,過濾 PR 問題表格中不需要處理的問題。
|
||||||
- 驗收:log 中能看到排除問題檔案讀取成功或不存在的訊息、規則過濾數量變化,以及「AI 誤報過濾: N -> M 筆」或降級訊息。
|
- 驗收:log 中能看到排除問題檔案讀取成功或不存在的訊息,以及過濾後 findings 數量變化。
|
||||||
- 完成
|
- 完成
|
||||||
|
|
||||||
## 階段五:findings 寫入與 comment 發布
|
## 階段五:findings 寫入與 comment 發布
|
||||||
- 目標:`.gitea/ai-review/findings.json` 正確寫入,comment 發布順序正確(舊問題→非嚴重→嚴重),每步有 log。
|
- 目標:findings.jsonl 正確寫入,comment 發布順序正確(舊問題→非嚴重→嚴重),每步有 log。
|
||||||
- 驗收:log 中能看到 `.gitea/ai-review/findings.json` 寫入、comment sync 的詳細訊息與順序。
|
- 驗收:log 中能看到 findings 寫入、comment sync 的詳細訊息與順序。
|
||||||
- 完成
|
- 完成
|
||||||
|
|
||||||
## 階段六:記憶區 commit/push 與錯誤處理
|
## 階段六:記憶區 commit/push 與錯誤處理
|
||||||
|
|||||||
+58
@@ -72,7 +72,53 @@ inputs:
|
|||||||
description: 'Amazon Q Base URL'
|
description: 'Amazon Q Base URL'
|
||||||
required: false
|
required: false
|
||||||
|
|
||||||
|
# SonarQube
|
||||||
|
SONARQUBE_TOKEN:
|
||||||
|
description: 'SonarQube Token'
|
||||||
|
required: false
|
||||||
|
SONARQUBE_URL:
|
||||||
|
description: 'SonarQube URL'
|
||||||
|
required: false
|
||||||
|
|
||||||
|
# Kilo Code
|
||||||
|
KILO_API_KEY:
|
||||||
|
description: 'Kilo Code API Key'
|
||||||
|
required: false
|
||||||
|
KILO_BASE_URL:
|
||||||
|
description: 'Kilo Code Base URL'
|
||||||
|
required: false
|
||||||
|
|
||||||
|
# Roo Code
|
||||||
|
ROO_API_KEY:
|
||||||
|
description: 'Roo Code API Key'
|
||||||
|
required: false
|
||||||
|
ROO_BASE_URL:
|
||||||
|
description: 'Roo Code Base URL'
|
||||||
|
required: false
|
||||||
|
|
||||||
|
# Cline
|
||||||
|
CLINE_API_KEY:
|
||||||
|
description: 'Cline API Key'
|
||||||
|
required: false
|
||||||
|
CLINE_BASE_URL:
|
||||||
|
description: 'Cline Base URL'
|
||||||
|
required: false
|
||||||
|
|
||||||
|
# Continue
|
||||||
|
CONTINUE_API_KEY:
|
||||||
|
description: 'Continue API Key'
|
||||||
|
required: false
|
||||||
|
CONTINUE_BASE_URL:
|
||||||
|
description: 'Continue Base URL'
|
||||||
|
required: false
|
||||||
|
|
||||||
|
# Kade
|
||||||
|
KADE_API_KEY:
|
||||||
|
description: 'Kade API Key'
|
||||||
|
required: false
|
||||||
|
KADE_BASE_URL:
|
||||||
|
description: 'Kade Base URL'
|
||||||
|
required: false
|
||||||
|
|
||||||
runs:
|
runs:
|
||||||
using: 'docker'
|
using: 'docker'
|
||||||
@@ -99,3 +145,15 @@ runs:
|
|||||||
OLLAMA_MODEL: ${{ inputs.OLLAMA_MODEL }}
|
OLLAMA_MODEL: ${{ inputs.OLLAMA_MODEL }}
|
||||||
AMAZONQ_API_KEY: ${{ inputs.AMAZONQ_API_KEY }}
|
AMAZONQ_API_KEY: ${{ inputs.AMAZONQ_API_KEY }}
|
||||||
AMAZONQ_BASE_URL: ${{ inputs.AMAZONQ_BASE_URL }}
|
AMAZONQ_BASE_URL: ${{ inputs.AMAZONQ_BASE_URL }}
|
||||||
|
SONARQUBE_TOKEN: ${{ inputs.SONARQUBE_TOKEN }}
|
||||||
|
SONARQUBE_URL: ${{ inputs.SONARQUBE_URL }}
|
||||||
|
KILO_API_KEY: ${{ inputs.KILO_API_KEY }}
|
||||||
|
KILO_BASE_URL: ${{ inputs.KILO_BASE_URL }}
|
||||||
|
ROO_API_KEY: ${{ inputs.ROO_API_KEY }}
|
||||||
|
ROO_BASE_URL: ${{ inputs.ROO_BASE_URL }}
|
||||||
|
CLINE_API_KEY: ${{ inputs.CLINE_API_KEY }}
|
||||||
|
CLINE_BASE_URL: ${{ inputs.CLINE_BASE_URL }}
|
||||||
|
CONTINUE_API_KEY: ${{ inputs.CONTINUE_API_KEY }}
|
||||||
|
CONTINUE_BASE_URL: ${{ inputs.CONTINUE_BASE_URL }}
|
||||||
|
KADE_API_KEY: ${{ inputs.KADE_API_KEY }}
|
||||||
|
KADE_BASE_URL: ${{ inputs.KADE_BASE_URL }}
|
||||||
|
|||||||
+7
-2
@@ -12,9 +12,14 @@ export function getLLMConfig() {
|
|||||||
const checks = [
|
const checks = [
|
||||||
['openai', process.env.OPENAI_API_KEY, process.env.OPENAI_BASE_URL || 'https://api.openai.com/v1', process.env.OPENAI_MODEL || 'gpt-4o-mini'],
|
['openai', process.env.OPENAI_API_KEY, process.env.OPENAI_BASE_URL || 'https://api.openai.com/v1', process.env.OPENAI_MODEL || 'gpt-4o-mini'],
|
||||||
['claude', process.env.CLAUDE_API_KEY, process.env.CLAUDE_BASE_URL || 'https://api.anthropic.com/v1', process.env.CLAUDE_MODEL || 'claude-3-haiku-20240307'],
|
['claude', process.env.CLAUDE_API_KEY, process.env.CLAUDE_BASE_URL || 'https://api.anthropic.com/v1', process.env.CLAUDE_MODEL || 'claude-3-haiku-20240307'],
|
||||||
['gemini', process.env.GEMINI_API_KEY, process.env.GEMINI_BASE_URL || 'https://generativelanguage.googleapis.com/v1beta', process.env.GEMINI_MODEL || 'gemini-2.5-flash'],
|
['gemini', process.env.GEMINI_API_KEY, process.env.GEMINI_BASE_URL || 'https://generativelanguage.googleapis.com/v1beta', process.env.GEMINI_MODEL || 'gemini-1.5-flash'],
|
||||||
['ollama', 'ollama', process.env.OLLAMA_BASE_URL, process.env.OLLAMA_MODEL],
|
['ollama', 'ollama', process.env.OLLAMA_BASE_URL, process.env.OLLAMA_MODEL],
|
||||||
['amazonq', process.env.AMAZONQ_API_KEY, process.env.AMAZONQ_BASE_URL || 'https://q.api.aws', process.env.AMAZONQ_MODEL || 'amazon-q'],
|
['amazonq', process.env.AMAZONQ_API_KEY, process.env.AMAZONQ_BASE_URL || 'https://q.api.aws', process.env.OPENAI_MODEL || 'amazon-q'],
|
||||||
|
['kilo', process.env.KILO_API_KEY, process.env.KILO_BASE_URL || 'https://api.kilocode.com/v1', process.env.OPENAI_MODEL || 'kilo-default'],
|
||||||
|
['roo', process.env.ROO_API_KEY, process.env.ROO_BASE_URL || 'https://api.roocode.com/v1', process.env.OPENAI_MODEL || 'roo-default'],
|
||||||
|
['cline', process.env.CLINE_API_KEY, process.env.CLINE_BASE_URL || 'https://api.cline.dev/v1', process.env.OPENAI_MODEL || 'cline-default'],
|
||||||
|
['continue', process.env.CONTINUE_API_KEY, process.env.CONTINUE_BASE_URL || 'https://api.continue.dev/v1', process.env.OPENAI_MODEL || 'continue-default'],
|
||||||
|
['kade', process.env.KADE_API_KEY, process.env.KADE_BASE_URL || 'https://api.kade.dev/v1', process.env.OPENAI_MODEL || 'kade-default'],
|
||||||
];
|
];
|
||||||
for (const [provider, key, baseURL, model] of checks) {
|
for (const [provider, key, baseURL, model] of checks) {
|
||||||
if (key && baseURL) return { provider, apiKey: key, baseURL, model };
|
if (key && baseURL) return { provider, apiKey: key, baseURL, model };
|
||||||
|
|||||||
@@ -1,101 +0,0 @@
|
|||||||
import { describe, it, beforeEach, afterEach } from 'node:test';
|
|
||||||
import assert from 'node:assert/strict';
|
|
||||||
import { getLLMConfig } from './config.js';
|
|
||||||
|
|
||||||
const ENV_KEYS = [
|
|
||||||
'OPENAI_API_KEY', 'OPENAI_BASE_URL', 'OPENAI_MODEL',
|
|
||||||
'CLAUDE_API_KEY', 'CLAUDE_BASE_URL', 'CLAUDE_MODEL',
|
|
||||||
'GEMINI_API_KEY', 'GEMINI_BASE_URL', 'GEMINI_MODEL',
|
|
||||||
'OLLAMA_BASE_URL', 'OLLAMA_MODEL',
|
|
||||||
'AMAZONQ_API_KEY', 'AMAZONQ_BASE_URL', 'AMAZONQ_MODEL',
|
|
||||||
];
|
|
||||||
|
|
||||||
let saved = {};
|
|
||||||
beforeEach(() => {
|
|
||||||
saved = {};
|
|
||||||
for (const k of ENV_KEYS) { saved[k] = process.env[k]; delete process.env[k]; }
|
|
||||||
});
|
|
||||||
afterEach(() => {
|
|
||||||
for (const k of ENV_KEYS) {
|
|
||||||
if (saved[k] === undefined) delete process.env[k];
|
|
||||||
else process.env[k] = saved[k];
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
describe('getLLMConfig', () => {
|
|
||||||
it('returns null provider when no env vars set', () => {
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, null);
|
|
||||||
assert.equal(cfg.apiKey, null);
|
|
||||||
});
|
|
||||||
|
|
||||||
it('detects openai with defaults', () => {
|
|
||||||
process.env.OPENAI_API_KEY = 'sk-test';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'openai');
|
|
||||||
assert.equal(cfg.apiKey, 'sk-test');
|
|
||||||
assert.equal(cfg.baseURL, 'https://api.openai.com/v1');
|
|
||||||
assert.equal(cfg.model, 'gpt-4o-mini');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('detects openai with custom base url and model', () => {
|
|
||||||
process.env.OPENAI_API_KEY = 'sk-test';
|
|
||||||
process.env.OPENAI_BASE_URL = 'https://openrouter.ai/api/v1';
|
|
||||||
process.env.OPENAI_MODEL = 'gpt-4o';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'openai');
|
|
||||||
assert.equal(cfg.baseURL, 'https://openrouter.ai/api/v1');
|
|
||||||
assert.equal(cfg.model, 'gpt-4o');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('detects gemini with defaults', () => {
|
|
||||||
process.env.GEMINI_API_KEY = 'gemini-key';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'gemini');
|
|
||||||
assert.equal(cfg.model, 'gemini-2.5-flash');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('detects gemini with custom model', () => {
|
|
||||||
process.env.GEMINI_API_KEY = 'gemini-key';
|
|
||||||
process.env.GEMINI_MODEL = 'gemini-2.0-flash';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.model, 'gemini-2.0-flash');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('detects claude with defaults', () => {
|
|
||||||
process.env.CLAUDE_API_KEY = 'claude-key';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'claude');
|
|
||||||
assert.equal(cfg.model, 'claude-3-haiku-20240307');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('detects amazonq with its own model env', () => {
|
|
||||||
process.env.AMAZONQ_API_KEY = 'aq-key';
|
|
||||||
process.env.AMAZONQ_MODEL = 'my-amazon-model';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'amazonq');
|
|
||||||
assert.equal(cfg.model, 'my-amazon-model');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('openai takes priority over gemini when both set', () => {
|
|
||||||
process.env.OPENAI_API_KEY = 'sk-test';
|
|
||||||
process.env.GEMINI_API_KEY = 'gemini-key';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'openai');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('empty string api key is treated as not set', () => {
|
|
||||||
process.env.OPENAI_API_KEY = '';
|
|
||||||
process.env.GEMINI_API_KEY = 'gemini-key';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'gemini');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('detects ollama without api key', () => {
|
|
||||||
process.env.OLLAMA_BASE_URL = 'http://localhost:11434';
|
|
||||||
process.env.OLLAMA_MODEL = 'llama3';
|
|
||||||
const cfg = getLLMConfig();
|
|
||||||
assert.equal(cfg.provider, 'ollama');
|
|
||||||
assert.equal(cfg.model, 'llama3');
|
|
||||||
});
|
|
||||||
});
|
|
||||||
+2
-36
@@ -124,43 +124,9 @@ export function applyExclusions(findings, exclusions) {
|
|||||||
const before = findings.length;
|
const before = findings.length;
|
||||||
const filtered = findings.filter(f => !exclusions.some(ex =>
|
const filtered = findings.filter(f => !exclusions.some(ex =>
|
||||||
(!ex.role || ex.role === f.role) &&
|
(!ex.role || ex.role === f.role) &&
|
||||||
(!ex.location || String(f.location).includes(ex.location)) &&
|
(!ex.location || ex.location === f.location) &&
|
||||||
(!ex.suggestion || String(f.suggestion).includes(String(ex.suggestion).slice(0, 20)))
|
(!ex.suggestion || String(f.suggestion).startsWith(String(ex.suggestion).slice(0, 50)))
|
||||||
));
|
));
|
||||||
console.log(` 排除過濾: ${before} -> ${filtered.length} 筆(排除 ${before - filtered.length} 筆)`);
|
console.log(` 排除過濾: ${before} -> ${filtered.length} 筆(排除 ${before - filtered.length} 筆)`);
|
||||||
return filtered;
|
return filtered;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
|
||||||
* 呼叫 AI 判斷哪些問題是誤報或不需處理,回傳需保留的 findings
|
|
||||||
* 失敗時降級回傳原始 findings
|
|
||||||
*/
|
|
||||||
export async function filterFalsePositivesWithAI(findings) {
|
|
||||||
if (findings.length === 0) return findings;
|
|
||||||
|
|
||||||
const systemPrompt = `你是一位資深程式碼審查專家,負責判斷審查問題是否為誤報或不需處理。
|
|
||||||
給你一份問題清單(JSON 陣列),每筆包含 level、role、location、suggestion。
|
|
||||||
請移除以下類型的問題:
|
|
||||||
1. 誤報:問題描述與實際程式碼不符(例如:程式碼已正確使用環境變數或 secrets,卻被標記為硬編碼敏感資料)
|
|
||||||
2. 不適用:問題在此專案情境下不需處理(例如:CI/CD action 本來就需要透過環境變數傳遞 token)
|
|
||||||
只回傳需要保留的問題 JSON 陣列,不要有其他文字。`;
|
|
||||||
|
|
||||||
const userContent = `請判斷以下問題清單,移除誤報或不需處理的問題:\n\n${JSON.stringify(findings, null, 2)}`;
|
|
||||||
|
|
||||||
try {
|
|
||||||
const result = await chatJSON(systemPrompt, userContent);
|
|
||||||
if (Array.isArray(result) && result.length > 0) {
|
|
||||||
console.log(` AI 誤報過濾: ${findings.length} -> ${result.length} 筆`);
|
|
||||||
return result;
|
|
||||||
}
|
|
||||||
throw new Error('AI 回傳空陣列或非陣列');
|
|
||||||
} catch (e) {
|
|
||||||
const status = e.response?.status;
|
|
||||||
if (status === 402 || status === 429) {
|
|
||||||
console.log(` ⚠️ AI 誤報過濾失敗(${status} 額度/限流),降級:保留所有問題`);
|
|
||||||
} else {
|
|
||||||
console.log(` ⚠️ AI 誤報過濾失敗(${e.message}),降級:保留所有問題`);
|
|
||||||
}
|
|
||||||
return findings;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
+1
-57
@@ -3,7 +3,7 @@ import assert from 'node:assert/strict';
|
|||||||
import fs from 'fs';
|
import fs from 'fs';
|
||||||
import os from 'os';
|
import os from 'os';
|
||||||
import path from 'path';
|
import path from 'path';
|
||||||
import { commitAndPush, cloneRepo } from './git.js';
|
import { commitAndPush } from './git.js';
|
||||||
|
|
||||||
// --- helpers ---
|
// --- helpers ---
|
||||||
function makeTmpWorkspace() {
|
function makeTmpWorkspace() {
|
||||||
@@ -91,59 +91,3 @@ describe('commitAndPush', () => {
|
|||||||
await assert.doesNotReject(() => commitAndPush(workspace, failSpawn));
|
await assert.doesNotReject(() => commitAndPush(workspace, failSpawn));
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
describe('cloneRepo', () => {
|
|
||||||
let workspace;
|
|
||||||
|
|
||||||
before(() => { workspace = fs.mkdtempSync(path.join(os.tmpdir(), 'clone-test-')); });
|
|
||||||
after(() => { fs.rmSync(workspace, { recursive: true, force: true }); });
|
|
||||||
|
|
||||||
it('clones repo when repoDir does not exist', () => {
|
|
||||||
const spawn = makeSpawn();
|
|
||||||
cloneRepo(workspace, spawn);
|
|
||||||
const cloneCalled = spawn.calls.some(c => c.args[0] === 'clone');
|
|
||||||
assert.ok(cloneCalled, 'expected git clone to be called');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('fetches and checks out when repoDir already exists', () => {
|
|
||||||
const repoDir = path.join(workspace, 'repo');
|
|
||||||
fs.mkdirSync(repoDir, { recursive: true });
|
|
||||||
const spawn = makeSpawn();
|
|
||||||
cloneRepo(workspace, spawn);
|
|
||||||
const cloneCalled = spawn.calls.some(c => c.args[0] === 'clone');
|
|
||||||
const fetchCalled = spawn.calls.some(c => c.args[0] === 'fetch');
|
|
||||||
assert.ok(!cloneCalled, 'clone should not run when repoDir exists');
|
|
||||||
assert.ok(fetchCalled, 'fetch should run when repoDir exists');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('does not embed token in any git command argument', () => {
|
|
||||||
const spawn = makeSpawn();
|
|
||||||
cloneRepo(workspace, spawn);
|
|
||||||
for (const { args } of spawn.calls) {
|
|
||||||
assert.ok(!args.join(' ').includes('test-token'), `Token leaked in git args: ${args.join(' ')}`);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
it('uses GIT_ASKPASS for network operations', () => {
|
|
||||||
const spawn = makeSpawn();
|
|
||||||
cloneRepo(workspace, spawn);
|
|
||||||
const networkCalls = spawn.calls.filter(c => ['clone', 'fetch'].includes(c.args[0]));
|
|
||||||
assert.ok(networkCalls.length > 0, 'expected at least one network git call');
|
|
||||||
for (const { args, opts } of networkCalls) {
|
|
||||||
assert.ok(opts?.env?.GIT_ASKPASS, `GIT_ASKPASS missing for git ${args[0]}`);
|
|
||||||
}
|
|
||||||
});
|
|
||||||
|
|
||||||
it('cleans up askpass script after run', () => {
|
|
||||||
const spawn = makeSpawn();
|
|
||||||
cloneRepo(workspace, spawn);
|
|
||||||
const leftover = fs.readdirSync(workspace).filter(f => f.endsWith('.git-askpass.sh'));
|
|
||||||
assert.equal(leftover.length, 0, 'askpass script was not cleaned up');
|
|
||||||
});
|
|
||||||
|
|
||||||
it('returns repoDir path', () => {
|
|
||||||
const spawn = makeSpawn();
|
|
||||||
const result = cloneRepo(workspace, spawn);
|
|
||||||
assert.equal(result, path.join(workspace, 'repo'));
|
|
||||||
});
|
|
||||||
});
|
|
||||||
|
|||||||
+4
-5
@@ -1,7 +1,7 @@
|
|||||||
import { GITEA_REPOSITORY, PR_NUMBER, PR_HEAD_BRANCH, PR_BASE_BRANCH, getLLMConfig } from './config.js';
|
import { GITEA_REPOSITORY, PR_NUMBER, PR_HEAD_BRANCH, PR_BASE_BRANCH, getLLMConfig } from './config.js';
|
||||||
import { loadRoles, getRoleIntro } from './roles.js';
|
import { loadRoles, getRoleIntro } from './roles.js';
|
||||||
import { getPRDiff, postComment } from './gitea.js';
|
import { getPRDiff, postComment } from './gitea.js';
|
||||||
import { analyzeWithRole, loadOldFindings, mergeFindings, sortByLevel, deduplicateWithAI, loadExclusions, applyExclusions, filterFalsePositivesWithAI } from './findings.js';
|
import { analyzeWithRole, loadOldFindings, mergeFindings, sortByLevel, deduplicateWithAI, loadExclusions, applyExclusions } from './findings.js';
|
||||||
import { saveFindings, postOldFindingsComment, postNewNonCriticalComment, postNewCriticalComments } from './comments.js';
|
import { saveFindings, postOldFindingsComment, postNewNonCriticalComment, postNewCriticalComments } from './comments.js';
|
||||||
import { cloneRepo, commitAndPush } from './git.js';
|
import { cloneRepo, commitAndPush } from './git.js';
|
||||||
|
|
||||||
@@ -81,11 +81,10 @@ async function main() {
|
|||||||
const sorted = sortByLevel(deduped);
|
const sorted = sortByLevel(deduped);
|
||||||
console.log(` Step3b dedup findings total=${sorted.length} (critical=${sorted.filter(f=>f.level==='critical').length} warning=${sorted.filter(f=>f.level==='warning').length} info=${sorted.filter(f=>f.level==='info').length})`);
|
console.log(` Step3b dedup findings total=${sorted.length} (critical=${sorted.filter(f=>f.level==='critical').length} warning=${sorted.filter(f=>f.level==='warning').length} info=${sorted.filter(f=>f.level==='info').length})`);
|
||||||
|
|
||||||
// Step4: 讀取排除問題檔案,過濾 PR 問題表格,並請 AI 判斷誤報
|
// Step4: 讀取排除問題檔案,過濾 PR 問題表格
|
||||||
console.log('\n🚫 Step4: AI 排除問題過濾');
|
console.log('\n🚫 Step4: 排除問題過濾');
|
||||||
const exclusions = loadExclusions(repoDir || WORKSPACE);
|
const exclusions = loadExclusions(repoDir || WORKSPACE);
|
||||||
const ruleFiltered = applyExclusions(sorted, exclusions);
|
const filtered = applyExclusions(sorted, exclusions);
|
||||||
const filtered = await filterFalsePositivesWithAI(ruleFiltered);
|
|
||||||
console.log(` Step4 完成: findings total=${filtered.length}`);
|
console.log(` Step4 完成: findings total=${filtered.length}`);
|
||||||
|
|
||||||
// Step5: 寫入 findings.json,依序發布 comment
|
// Step5: 寫入 findings.json,依序發布 comment
|
||||||
|
|||||||
+2
-6
@@ -12,13 +12,9 @@ export function loadRoles() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export function getRoleIntro(roles) {
|
export function getRoleIntro(roles) {
|
||||||
const lines = [
|
const lines = ['## 🤖 AI Code Review 團隊', ''];
|
||||||
'## 🤖 AI Code Review 團隊', '',
|
|
||||||
'| 👤 名稱 | 🎯 職責 | 🧠 個性 |',
|
|
||||||
'|--------|--------|--------|',
|
|
||||||
];
|
|
||||||
for (const r of roles) {
|
for (const r of roles) {
|
||||||
lines.push(`| **${r.name}** | ${r.role} | ${r.personality} |`);
|
lines.push(`- **${r.name}** (${r.role}):${r.personality}`);
|
||||||
}
|
}
|
||||||
return lines.join('\n');
|
return lines.join('\n');
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user