actions/code-review
2
0
Fork 0
Code Pull Requests Actions Releases 2 Activity
361 Commits 2 Branches 234 Tags
07e38f9d459ba78a5bb144d3c7d8bc569bd9e80b
Commit Graph

105 Commits

Author SHA1 Message Date
Jeffery 9d780788e9 test: 補齊 runPreflight 測試並 triage preflight findings
AI / 計算版本號 (pull_request) Successful in 4s
Details
AI / Code Review (pull_request) Failing after 1m42s
Details 
triage 6 筆 review findings：1 筆修正、5 筆移入 exclusions。

修正（Maya, warning）：runPreflight 僅測過 env 缺失早退，缺成功路徑與
各失敗點覆蓋。將其驗證步驟改為可注入的 deps 參數（預設沿用原函式，
行為不變），並補上完整成功、comment 略過、各失敗點早停、workspace
傳遞共 8 個測試。

移入 exclusions（誤報，保留原文）：
- Rex critical：GITEA_SKIP_TLS_VERIFY 為預設開啟驗證的 opt-in 設定，
  與既有 gitea.js 排除一致，非漏洞
- Leo warning：verifyLLM 內聚清楚，拆分屬主觀重構
- Zara warning：每把 key 30s timeout 為刻意的可靠性下限，僅失敗時累積
- Rex info：axios 錯誤訊息不含認證標頭/內容
- Aria info：預設參數引用 config 常數為刻意且利於測試的 pattern

findings.json 清空（全部已修正或排除）。app/ 測試 112 pass。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-16 13:49:30 +08:00
Jeffery 7339145641 fix: withAskpass 等待非同步 callback 完成才清理 askpass 腳本
AI / 計算版本號 (pull_request) Successful in 2s
Details
AI / Code Review (pull_request) Failing after 2m24s
Details 
commitAndPush 傳入 async callback，但 withAskpass 是同步 try/finally，
會在第一個 await（LLM 合併指令檔）時就刪除 .git-askpass.sh，導致後續
git push 因 GIT_ASKPASS 指向已刪除腳本而失敗（cannot exec .git-askpass.sh /
could not read Username）。前置驗證的 verifyRemoteAccess 用同步 callback
所以 ls-remote 通過，造成前置驗證過但 push 失敗的落差。

改為當 callback 回傳 thenable 時以 result.finally(cleanup) 延後清理，
同步 callback 維持立即清理與原樣回傳，不影響 verifyRemoteAccess / cloneRepo。

新增回歸測試斷言 git push 執行當下 askpass 腳本仍存在。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-16 11:40:58 +08:00
Jeffery 40ebfe99a8 feat: 前置驗證納入 git push 認證檢查
AI / 計算版本號 (pull_request) Successful in 2s
Details
AI / Code Review (pull_request) Failing after 1m28s
Details 
git push 走 askpass + HTTP 認證，與 Gitea REST API 是兩套機制，API token
有效不代表 push 能用（曾出現 askpass 無法執行、could not read Username 而
push 失敗）。新增 git.js verifyRemoteAccess() 以相同 askpass + remote URL
跑唯讀 git ls-remote，preflight 呼叫並在失敗時 exit 1，提前攔下設定問題。

新增 git.test.js 對 verifyRemoteAccess 的測試（成功、失敗不丟例外、token
不外洩、askpass 清理）。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-15 13:39:04 +08:00
Jeffery 766f2ddf40 feat: 啟動時前置驗證所有驗證相關設定
AI / 計算版本號 (pull_request) Failing after 1s
Details
AI / Code Review (pull_request) Has been skipped
Details 
新增 app/preflight.js，在 action 啟動（Step1 之後、其餘步驟之前）集中
檢查必要環境變數、GITEA_TOKEN 讀 repo、GITEA_COMMENT_TOKEN、以及 LLM
provider/API Key（多把只要一把通過即可，Ollama 改檢查 base URL 連線）。
任一項失敗即印出原因並 exit 1，避免分析到一半或發 comment 時才失敗。

main.js 在 Step1 後呼叫 runPreflight()；新增 preflight.test.js 覆蓋
成功、缺環境變數、token 無效、所有 LLM key 失敗、Ollama 等情境。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-15 10:41:40 +08:00
Jeffery 097b6fb721 feat: implement Git integration for automated repository instruction syncing and commit management 2026-05-21 11:36:11 +08:00
Jeffery e99236b893 feat: implement git repository synchronization and automated commit functionality for AI review findings 2026-05-21 10:17:01 +08:00
Jeffery e80a462d96 feat: 將 ANTIGRAVITY 加入程式 2026-05-20 10:49:34 +08:00
jiantw83 b4c54124ec feat: force overwrite core instruction files 2026-05-18 02:50:47 +00:00
jiantw83 b51ab78a5e feat: force sync skill trees 2026-05-18 02:48:54 +00:00
jiantw83 b8294d5ca7 fix: persist repaired exclusions 2026-05-18 02:40:53 +00:00
jiantw83 b1ed236720 feat: normalize exclusions format 2026-05-18 02:33:24 +00:00
jiantw83 d18c4a4a8e feat: optimize exclusion filtering 2026-05-18 02:06:36 +00:00
jiantw83 86d8666cda test: cover log helpers 2026-05-15 15:51:56 +00:00
jiantw83 c836ec08e4 chore: triage log output suggestions 2026-05-15 15:45:08 +00:00
jiantw83 38a3349e4f chore: refine pipeline stage logs 2026-05-15 15:32:43 +00:00
jiantw83 3fcbf788fc chore: unify log formatting 2026-05-15 15:25:26 +00:00
jiantw83 ce53c67cac fix: fail workflow on bot failure marker 2026-05-15 15:05:52 +00:00
jiantw83 b0c4d5a0bc feat: split gitea comment token 2026-05-15 14:59:15 +00:00
jiantw83 066b21aa5c feat: encode ai review outcome in commit marker 2026-05-15 14:47:02 +00:00
jiantw83 4fd9a22aa0 feat: report ai review commit status 2026-05-15 14:39:15 +00:00
jiantw83 35150cae8a chore: expand bot check diagnostics 2026-05-15 14:30:39 +00:00
jiantw83 888bf0b359 test: add bot check debug logs 2026-05-15 14:25:08 +00:00
jiantw83 82ecbd3463 fix: detect ai review bot commits via api 2026-05-15 14:17:55 +00:00
jiantw83 9012fe64d1 chore: skip ai review bot commits 2026-05-15 14:11:21 +00:00
jiantw83 60f3a9beba fix: skip ai review bot commits 2026-05-15 14:00:59 +00:00
jiantw83 222de4b369 feat: enhance findings and exclusions handling with repo state logging 2026-05-15 09:39:11 +00:00
jiantw83 8bf791a829 fix: clarify stage seven push failures 2026-05-15 06:51:56 +00:00
jiantw83 c88c0d02c8 docs: clarify source branch review files 2026-05-15 06:43:20 +00:00
jiantw83 f43ba63f0f fix: support wrapped exclusions schema 2026-05-15 06:39:17 +00:00
jiantw83 4a29c4aaa3 fix: refresh repo before staging review files 2026-05-15 06:23:07 +00:00
jiantw83 78ec8f6d6a test: cover saveFindings temp dir cases 2026-05-15 06:17:09 +00:00
jiantw83 5c5773e4fd fix: write findings to review dir 2026-05-15 06:10:09 +00:00
jiantw83 ece7377fc8 fix: stage generated review files 2026-05-15 05:47:06 +00:00
jiantw83 33d5cdde7c fix: sync codex skill assets 2026-05-15 04:15:01 +00:00
jiantw83 109048e604 fix: package triage skills into the action image 2026-05-15 03:48:05 +00:00
jiantw83 7186098edf fix: restore triage skill files and keep sync non-destructive 2026-05-15 03:30:48 +00:00
jiantw83 c70a818986 fix: mirror sync files before commit 2026-05-15 03:09:54 +00:00
jiantw83 684c35bc00 fix: skip missing sync paths in commit step 2026-05-15 03:04:27 +00:00
jiantw83 b397b76a7a chore: triage review findings 2026-05-14 02:37:45 +00:00
jiantw83 12980d6ca4 fix: dedupe sync paths in git tests 2026-05-14 02:22:50 +00:00
jiantw83 1ad87ac4a4 fix: address triaged review findings 2026-05-14 02:18:17 +00:00
jiantw83 4492fcbdd6 feat: sync triage skill files 2026-05-14 02:13:08 +00:00
jiantw83 098d4aea97 feat: expand diff exclusions 2026-05-14 02:13:08 +00:00
jiantw83 d8c3bdfde2 feat: tighten json validation repair flow 2026-05-14 01:23:59 +00:00
jiantw83 dbc387692d chore: refine stage 7 json validation 2026-05-14 00:54:53 +00:00
jiantw83 cc6345c32e refactor: update commitAndPush function to accept repoDir parameter and adjust related tests 2026-05-13 01:46:27 +00:00
jiantw83 5876154dbb refactor: optimize AI payload by reducing token usage and streamline findings structure 2026-05-13 01:39:13 +00:00
jiantw83 8d8ace636e refactor: add new suggestion for filterDiff unit tests and update getPRDiff documentation for clarity 2026-05-13 01:27:33 +00:00
jiantw83 fade942267 refactor: add new suggestion for comments.js and enhance filterDiff tests for better coverage 2026-05-13 01:18:21 +00:00
jiantw83 4834396652 refactor: streamline JSON file reading logic and improve error handling in findings.js and git.js 2026-05-13 01:16:34 +00:00