actions/code-review
2
0
Fork 0
Code Pull Requests Actions Releases 2 Activity
361 Commits 2 Branches 234 Tags
07e38f9d459ba78a5bb144d3c7d8bc569bd9e80b
Commit Graph

39 Commits

Author SHA1 Message Date
Jeffery 33f1291a0f chore: triage preflight TLS finding 為誤報並寫入 exclusions
AI / 計算版本號 (pull_request) Successful in 4s
Details
AI / Code Review (pull_request) Successful in 4m16s
Details 
Maya critical（app/preflight.js:107）：verifyLLM 的 axios.post 未帶
httpsAgent，認為 GITEA_SKIP_TLS_VERIFY 未套用到 LLM 請求。

判定為誤報並移入 exclusions：
- GITEA_SKIP_TLS_VERIFY 為 Gitea 端（內網自簽憑證）專用設定，外部 LLM
  服務（Gemini/OpenAI/Claude）應維持 TLS 驗證，套用此 flag 屬安全降級
- 與既有 app/llm.js 排除一致（已刻意移除 rejectUnauthorized:false 還原
  TLS 驗證）

findings.json 清空（已排除）。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-16 14:15:00 +08:00
Jeffery 9d780788e9 test: 補齊 runPreflight 測試並 triage preflight findings
AI / 計算版本號 (pull_request) Successful in 4s
Details
AI / Code Review (pull_request) Failing after 1m42s
Details 
triage 6 筆 review findings：1 筆修正、5 筆移入 exclusions。

修正（Maya, warning）：runPreflight 僅測過 env 缺失早退，缺成功路徑與
各失敗點覆蓋。將其驗證步驟改為可注入的 deps 參數（預設沿用原函式，
行為不變），並補上完整成功、comment 略過、各失敗點早停、workspace
傳遞共 8 個測試。

移入 exclusions（誤報，保留原文）：
- Rex critical：GITEA_SKIP_TLS_VERIFY 為預設開啟驗證的 opt-in 設定，
  與既有 gitea.js 排除一致，非漏洞
- Leo warning：verifyLLM 內聚清楚，拆分屬主觀重構
- Zara warning：每把 key 30s timeout 為刻意的可靠性下限，僅失敗時累積
- Rex info：axios 錯誤訊息不含認證標頭/內容
- Aria info：預設參數引用 config 常數為刻意且利於測試的 pattern

findings.json 清空（全部已修正或排除）。app/ 測試 112 pass。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
 2026-06-16 13:49:30 +08:00
Jeffery fbff9b3a86 chore: initialize ai-review exclusion and findings configuration files 2026-05-21 11:52:18 +08:00
jiantw83 09584f4f93 chore: triage ai review findings 2026-05-18 02:55:43 +00:00
jiantw83 c836ec08e4 chore: triage log output suggestions 2026-05-15 15:45:08 +00:00
jiantw83 45e875153c chore: triage review findings 2026-05-15 15:13:07 +00:00
jiantw83 e5539c377c docs: exclude triage skill sync false positives 2026-05-15 03:55:12 +00:00
jiantw83 b397b76a7a chore: triage review findings 2026-05-14 02:37:45 +00:00
jiantw83 d8c3bdfde2 feat: tighten json validation repair flow 2026-05-14 01:23:59 +00:00
jiantw83 5e623a3f2e docs: exclude current review findings 2026-05-13 06:27:43 +00:00
jiantw83 0c9748049c Revert "test: cover review edge cases and repair paths" 
This reverts commit 61942eeebbba95c81431896c7fd8f43ff0e7c0d5.
 2026-05-13 06:27:43 +00:00
jiantw83 3f3ead0f08 test: cover review edge cases and repair paths 2026-05-13 06:27:43 +00:00
jiantw83 8872e7366a refactor: add performance improvement suggestion for filterDiff regex in exclusions.json 2026-05-13 02:23:30 +00:00
jiantw83 9bef365a32 refactor: enhance suggestions in exclusions.json for improved security and efficiency 2026-05-13 02:16:13 +00:00
jiantw83 fcc8d59f7a refactor: add suggestion for TODO.md clarification and enhance filterDiff test documentation 2026-05-13 01:31:25 +00:00
jiantw83 8d8ace636e refactor: add new suggestion for filterDiff unit tests and update getPRDiff documentation for clarity 2026-05-13 01:27:33 +00:00
jiantw83 fade942267 refactor: add new suggestion for comments.js and enhance filterDiff tests for better coverage 2026-05-13 01:18:21 +00:00
jiantw83 49a02ebb6b feat: add JSON format validation for findings and exclusions after processing 2026-05-13 01:02:33 +00:00
jiantw83 c751a53d43 feat: enhance exclusions.json with new suggestions and refactor roles.js for dynamic path resolution 2026-05-12 09:57:33 +00:00
jiantw83 81d5e3ff13 feat: update exclusions.json suggestions and refactor Dockerfile for improved npm installation 2026-05-12 09:40:56 +00:00
jiantw83 1ccc2cd560 feat: add GITEA_SKIP_TLS_VERIFY support for skipping SSL/TLS verification in Gitea integration 2026-05-12 09:37:51 +00:00
jiantw83 9650162a67 feat: extend GEMINI_API_KEY support to include additional keys and update suggestions in exclusions.json 2026-05-12 09:21:32 +00:00
jiantw83 95929fdced feat: add suggestions for master.yaml and llm.test.js to improve code quality and testing practices 2026-05-12 08:41:23 +00:00
jiantw83 b149508dab feat: enhance exclusions.json with additional suggestions and add chatJSON tests for JSON response handling 2026-05-12 08:29:24 +00:00
jiantw83 bb18147cab feat: update exclusions.json with additional suggestions and refine master.yaml for cleaner token handling 2026-05-12 08:29:24 +00:00
jiantw83 8a8612b46d fix: update findings.json to remove redundant warnings and ensure consistency with exclusions.json 2026-05-12 06:46:51 +00:00
jiantw83 fdcb9f04de fix: update suggestions in exclusions.json to clarify handling of findings and LLM service provider maintenance 2026-05-12 06:29:43 +00:00
jiantw83 e3596eb710 fix: add duplicate suggestion for LLM integration tests in exclusions.json 2026-05-12 06:28:34 +00:00
jiantw83 234a8a829f fix: update suggestion in exclusions.json for LLM integration tests to clarify API key requirements 2026-05-12 06:21:24 +00:00
jiantw83 4bace91d3d fix: add suggestions for LLM integration tests and code structure improvements in exclusions.json; ensure findings.json is saved with a newline 2026-05-12 06:03:30 +00:00
jiantw83 95802c422b fix: update suggestions in exclusions.json and findings.json for clarity and consistency with GEMINI API 2026-05-12 05:54:25 +00:00
jiantw83 bf7b8f843b fix: add suggestion for GEMINI API parameter consistency in review.yaml 2026-05-12 05:50:46 +00:00
jiantw83 58fdbdd965 fix: enhance exclusions.json suggestions for clarity; remove unnecessary lines in action.yaml 2026-05-12 05:37:07 +00:00
jiantw83 5ef9ab81ff fix: enhance suggestions in exclusions.json for clarity and accuracy; update filterFalsePositivesWithAI to accept exclusions 2026-05-12 04:20:35 +00:00
jiantw83 33c0357165 fix: update suggestions in exclusions.json for clarity and accuracy 2026-05-12 04:05:49 +00:00
jiantw83 76c5160915 fix: add additional suggestions for AI review exclusions in exclusions.json 2026-05-12 03:42:57 +00:00
jiantw83 940d03bc6e fix: add suggestion for necessary permissions in README.md for Action functionality 2026-05-12 03:18:04 +00:00
jiantw83 d230b5f445 fix: add Leo/Zara false positive exclusion; add cloneRepo unit tests 2026-05-12 02:30:14 +00:00
jiantw83 58bea7951d chore: add exclusions for Rex false positive on git.js token handling 2026-05-12 02:30:14 +00:00