From c836ec08e4b931a0dd113aaf86b2f45b90b23930 Mon Sep 17 00:00:00 2001 From: Jeffery Date: Fri, 15 May 2026 15:45:08 +0000 Subject: [PATCH] chore: triage log output suggestions --- .gitea/ai-review/exclusions.json | 10 ++++++++++ app/git.test.js | 6 +++++- app/log.js | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/.gitea/ai-review/exclusions.json b/.gitea/ai-review/exclusions.json index 365ace9..072e4bf 100644 --- a/.gitea/ai-review/exclusions.json +++ b/.gitea/ai-review/exclusions.json @@ -329,5 +329,15 @@ "role": "Leo", "location": "action.yaml:80", "suggestion": "在 `runs.env` 區塊中,`GITEA_TOKEN` 只從 `inputs` 取得,而 `GITEA_SERVER_URL` 和 `GITEA_REPOSITORY` 仍保留從 `gitea context` 取得的備用機制,這是刻意設計的差異,不是維護缺陷。" + }, + { + "role": "Rex", + "location": "action.yaml:18", + "suggestion": "引入 `GITEA_COMMENT_TOKEN` 是一個很好的實踐,遵循最小權限原則。請確保為此 token 配置的權限確實僅限於發布評論。同時,與 `GITEA_TOKEN` 相似,建議使用者始終從 workflow 的 secrets context 傳遞此 token,以避免硬編碼敏感資料。" + }, + { + "role": "Leo", + "location": "app/log.js", + "suggestion": "考慮在日誌訊息中加入時間戳記,這有助於追蹤事件發生的順序,尤其是在長時間運行的程序或需要詳細調試時。可以在每個日誌函式內部自動添加時間戳記。" } ] diff --git a/app/git.test.js b/app/git.test.js index 24abf62..fd6543d 100644 --- a/app/git.test.js +++ b/app/git.test.js @@ -185,12 +185,16 @@ describe('commitAndPush', () => { }); const logs = []; const originalLog = console.log; - console.log = (...args) => { logs.push(args.join(' ')); }; + const originalWarn = console.warn; + const capture = (...args) => { logs.push(args.join(' ')); }; + console.log = capture; + console.warn = capture; try { await commitAndPush(workspace, repoDir, spawn, sourceRoot); } finally { console.log = originalLog; + console.warn = originalWarn; } assert.ok(logs.some(line => line.includes('Step7 commit 成功但 push 失敗'))); diff --git a/app/log.js b/app/log.js index cde500f..a2155bc 100644 --- a/app/log.js +++ b/app/log.js @@ -15,7 +15,7 @@ export function ok(message) { } export function warn(message) { - console.log(` ! ${message}`); + console.warn(` ! ${message}`); } export function error(message) {