actions/code-review
2
0
Fork 0
Code Pull Requests Actions Releases Activity

fix: align flow with README, add Step4 exclusions filter, fix step numbers

Browse Source
This commit is contained in:
Jeffery
2026-05-12 01:35:57 +00:00
parent 2460652b49
commit bb7fa425db
4 changed files with 64 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/main.js
+21 -17
View File
@@ -1,7 +1,7 @@
import { GITEA_REPOSITORY, PR_NUMBER, PR_HEAD_BRANCH, PR_BASE_BRANCH, getLLMConfig } from './config.js';
import { loadRoles, getRoleIntro } from './roles.js';
import { getPRDiff, postComment } from './gitea.js';
import { analyzeWithRole, loadOldFindings, mergeFindings, sortByLevel, deduplicateWithAI } from './findings.js';
import { analyzeWithRole, loadOldFindings, mergeFindings, sortByLevel, deduplicateWithAI, loadExclusions, applyExclusions } from './findings.js';
import { saveFindings, postOldFindingsComment, postNewNonCriticalComment, postNewCriticalComments } from './comments.js';
import { commitAndPush } from './git.js';
@@ -26,7 +26,6 @@ async function main() {
console.log(` 已載入 ${roles.length} 個角色: [${roles.map(r => r.name).join(', ')}]`);
// 取得 PR diff
console.log('\n📋 Step1: 取得 PR Diff');
let diff;
try {
diff = await getPRDiff();
@@ -42,7 +41,6 @@ async function main() {
}
// 發布角色介紹 comment
console.log('\n💬 Step1: 發布角色介紹 Comment');
try {
const intro = getRoleIntro(roles) + `\n\n> 🔍 服務：${provider} 模型：${model}`;
await postComment(intro);
@@ -50,6 +48,7 @@ async function main() {
} catch (e) {
console.log(` ⚠️ comment 發布失敗（繼續執行）: ${e.message}`);
}
console.log(' Step1 完成');
// Step2: 各角色分析 diff 產生新 findings
console.log('\n📊 Step2: Findings 產生');
@@ -64,38 +63,43 @@ async function main() {
}
console.log(` Step2 完成: 新 findings 總計 ${newFindings.length} 筆`);
// Step3: 讀取舊 findings，合併去重
// Step3: 讀取舊 findings，合併去重（含 AI 語意去重）
console.log('\n🔀 Step3: Findings 合併');
const oldFindings = loadOldFindings(WORKSPACE);
const mergedFindings = mergeFindings(oldFindings, newFindings);
console.log(` Step3 merged findings total=${mergedFindings.length}`);
// Step3b: AI 語意去重
console.log('\n🤖 Step3b: AI 語意去重');
const deduped = await deduplicateWithAI(mergedFindings);
const sorted = sortByLevel(deduped);
console.log(` Step3b dedup findings total=${sorted.length} (critical=${sorted.filter(f=>f.level==='critical').length} warning=${sorted.filter(f=>f.level==='warning').length} info=${sorted.filter(f=>f.level==='info').length})`);
// Step4: 寫入 findings.json，依序發布 comment
console.log('\n📝 Step4: Findings 寫入與 Comment 發布');
saveFindings(WORKSPACE, sorted);
// Step4: 讀取排除問題檔案，過濾 PR 問題表格
console.log('\n🚫 Step4: 排除問題過濾');
const exclusions = loadExclusions(WORKSPACE);
const filtered = applyExclusions(sorted, exclusions);
console.log(` Step4 完成: findings total=${filtered.length}`);
// Step5: 寫入 findings.json，依序發布 comment
console.log('\n📝 Step5: Findings 寫入與 Comment 發布');
saveFindings(WORKSPACE, filtered);
try {
await postOldFindingsComment(sorted);
await postNewNonCriticalComment(sorted);
await postNewCriticalComments(sorted);
console.log(' Step4 完成');
await postOldFindingsComment(filtered);
await postNewNonCriticalComment(filtered);
await postNewCriticalComments(filtered);
console.log(' Step5 完成');
} catch (e) {
console.log(` ⚠️ comment 發布失敗（繼續執行）: ${e.message}`);
}
// Step5: commit/push findings.json 到來源分支
console.log('\n💾 Step5: 記憶區 Commit/Push');
// Step6: commit/push findings.json 到來源分支
console.log('\n💾 Step6: 記憶區 Commit/Push');
await commitAndPush(WORKSPACE);
// Step6: 有 critical 問題則 exit 1
console.log('\n🚦 Step6: 嚴重問題檢查');
const criticalCount = sorted.filter(f => f.level === 'critical').length;
// Step7: 有 critical 問題則 exit 1
console.log('\n🚦 Step7: 嚴重問題檢查');
const criticalCount = filtered.filter(f => f.level === 'critical').length;
if (criticalCount > 0) {
console.log(` ❌ 發現 ${criticalCount} 個嚴重問題，workflow 結束（exit 1）`);
console.log('='.repeat(60));