actions/code-review
2
0
Fork 0
Code Pull Requests Actions Releases Activity

feat: refactor API key handling to shuffle keys and attempt each once

Browse Source
This commit is contained in:
Jeffery
2026-05-12 08:17:49 +00:00
parent e28c6ea5a3
commit a6df5c4f43
4 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/llm.test.js
+14 -14
View File
@@ -48,18 +48,18 @@ describe('chat - key rotation', async () => {
assert.equal(result, 'hello');
});
it('rotates to second key when first fails', async () => {
process.env.OPENAI_API_KEY = 'key1,key2';
mockAxiosPost([new Error('rate limit'), makeOkResponse('from key2')]);
const result = await chat('sys', 'user');
assert.equal(result, 'from key2');
});
it('rotates through all keys and succeeds on last', async () => {
process.env.OPENAI_API_KEY = 'k1,k2,k3';
mockAxiosPost([new Error('fail'), new Error('fail'), makeOkResponse('from k3')]);
const result = await chat('sys', 'user');
assert.equal(result, 'from k3');
it('shuffles keys and tries each exactly once', async () => {
process.env.OPENAI_API_KEY = 'key1,key2,key3';
const usedKeys = [];
mock.method(axios, 'post', async (_url, _body, opts) => {
usedKeys.push(opts.headers['Authorization'].replace('Bearer ', ''));
throw new Error('fail');
});
const exitMock = mock.method(process, 'exit', () => { throw new Error('exit:1'); });
await assert.rejects(() => chat('sys', 'user'), /exit:1/);
assert.equal(exitMock.mock.calls[0].arguments[0], 1);
assert.equal(usedKeys.length, 3);
assert.deepEqual([...usedKeys].sort(), ['key1', 'key2', 'key3']);
});
it('calls process.exit(1) when all keys fail', async () => {
@@ -93,7 +93,7 @@ describe('chat - key rotation', async () => {
assert.equal(capturedHeaders['Authorization'], 'Bearer sk-test');
});
it('uses 30s timeout', async () => {
it('does not set timeout', async () => {
process.env.OPENAI_API_KEY = 'sk-test';
let capturedOpts;
mock.method(axios, 'post', async (_url, _body, opts) => {
@@ -101,7 +101,7 @@ describe('chat - key rotation', async () => {
return makeOkResponse();
});
await chat('sys', 'user');
assert.equal(capturedOpts.timeout, 30000);
assert.equal(capturedOpts.timeout, undefined);
});
it('does not pass httpsAgent to axios', async () => {