From 915e9cc2da5e480798ffd54b99b4439b5aecfac3 Mon Sep 17 00:00:00 2001 From: Jeffery Date: Mon, 18 May 2026 02:35:35 +0000 Subject: [PATCH] docs: require canonical exclusions array --- .claude/skills/triage-findings/SKILL.md | 3 ++- .codex/skills/triage-findings/SKILL.md | 3 ++- .codex/skills/triage-findings/agents/openai.yaml | 2 +- .gemini/skills/triage-findings/SKILL.md | 3 ++- .github/skills/triage-findings/SKILL.md | 2 +- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.claude/skills/triage-findings/SKILL.md b/.claude/skills/triage-findings/SKILL.md index c4ab450..2bfa16f 100644 --- a/.claude/skills/triage-findings/SKILL.md +++ b/.claude/skills/triage-findings/SKILL.md @@ -18,7 +18,7 @@ description: Triage findings, fix real issues, and exclude false positives. - info 3. Renumber from 1. 4. Fix real issues. -5. Put false positives into `.gitea/ai-review/exclusions.json`, preserving the original wording, language, and semantics as much as possible. +5. Put false positives into `.gitea/ai-review/exclusions.json` as a top-level JSON array, preserving the original wording, language, and semantics as much as possible. Do not wrap the array in `exclusions` or `excluded_findings`. 6. Add tests when behavior changes. ## Output Rules @@ -26,4 +26,5 @@ description: Triage findings, fix real issues, and exclude false positives. - Keep the final list short. - Keep numbering contiguous. - Preserve file path, location, and fix. +- When writing exclusions, always output a top-level JSON array. - When writing exclusions, prefer the original issue text over paraphrased rewrites. diff --git a/.codex/skills/triage-findings/SKILL.md b/.codex/skills/triage-findings/SKILL.md index 21476cb..2422e52 100644 --- a/.codex/skills/triage-findings/SKILL.md +++ b/.codex/skills/triage-findings/SKILL.md @@ -21,7 +21,7 @@ It is also used when some findings are false positives and should be moved into 4. Renumber the sorted list from 1 upward. 5. Rewrite each finding concisely so the final list reads cleanly and consistently. 6. If a finding is a false positive, do not keep it in the final list. -7. Add false positives to the exclusions list using the existing schema in the repo or task context, and preserve the original finding wording as much as possible, including language and semantics. +7. Add false positives to the exclusions list as a top-level JSON array in `.gitea/ai-review/exclusions.json`, and preserve the original finding wording as much as possible, including language and semantics. Do not wrap the array in `exclusions` or `excluded_findings`. ## Resolution Flow @@ -41,5 +41,6 @@ After the list is merged and ordered, resolve the remaining findings one by one. - Keep numbering contiguous after filtering and merging. - Preserve useful details like file path, location, and suggested fix. - Keep exclusions entries minimal and consistent with the project schema. +- When writing exclusions, always output a top-level JSON array. - When writing exclusions, prefer the original issue text and language; only paraphrase if needed to fit the schema. - If the source already provides a severity or title, keep it unless it conflicts with the final ordering. diff --git a/.codex/skills/triage-findings/agents/openai.yaml b/.codex/skills/triage-findings/agents/openai.yaml index 6f59e2c..9b2c3ea 100644 --- a/.codex/skills/triage-findings/agents/openai.yaml +++ b/.codex/skills/triage-findings/agents/openai.yaml @@ -1,4 +1,4 @@ interface: display_name: "Triage Findings" short_description: "Triage, sort, fix, and exclude review findings" - default_prompt: "Use $triage-findings to merge review findings, sort and renumber them by severity, resolve real issues one by one, and add false positives to exclusions." + default_prompt: "Use $triage-findings to merge review findings, sort and renumber them by severity, resolve real issues one by one, and add false positives to `.gitea/ai-review/exclusions.json` as a top-level JSON array." diff --git a/.gemini/skills/triage-findings/SKILL.md b/.gemini/skills/triage-findings/SKILL.md index c4ab450..2bfa16f 100644 --- a/.gemini/skills/triage-findings/SKILL.md +++ b/.gemini/skills/triage-findings/SKILL.md @@ -18,7 +18,7 @@ description: Triage findings, fix real issues, and exclude false positives. - info 3. Renumber from 1. 4. Fix real issues. -5. Put false positives into `.gitea/ai-review/exclusions.json`, preserving the original wording, language, and semantics as much as possible. +5. Put false positives into `.gitea/ai-review/exclusions.json` as a top-level JSON array, preserving the original wording, language, and semantics as much as possible. Do not wrap the array in `exclusions` or `excluded_findings`. 6. Add tests when behavior changes. ## Output Rules @@ -26,4 +26,5 @@ description: Triage findings, fix real issues, and exclude false positives. - Keep the final list short. - Keep numbering contiguous. - Preserve file path, location, and fix. +- When writing exclusions, always output a top-level JSON array. - When writing exclusions, prefer the original issue text over paraphrased rewrites. diff --git a/.github/skills/triage-findings/SKILL.md b/.github/skills/triage-findings/SKILL.md index 8ca4117..42932fc 100644 --- a/.github/skills/triage-findings/SKILL.md +++ b/.github/skills/triage-findings/SKILL.md @@ -7,7 +7,7 @@ Use the triage-finding workflow for review issue lists: 3. Sort by severity: `critical` -> `warning` -> `info`. 4. Renumber from 1. 5. Fix real issues with the smallest safe change. -6. Put false positives into `.gitea/ai-review/exclusions.json`, preserving the original wording, language, and semantics as much as possible. +6. Put false positives into `.gitea/ai-review/exclusions.json` as a top-level JSON array, preserving the original wording, language, and semantics as much as possible. Do not wrap the array in `exclusions` or `excluded_findings`. 7. Add or update tests when behavior changes. 8. Re-check after each fix.