From 5478918e2511e631a4b4d937f356a365b8c5ace2 Mon Sep 17 00:00:00 2001 From: Jeffery Date: Thu, 14 May 2026 01:39:30 +0000 Subject: [PATCH] feat: add triage findings skill for managing review issues --- .codex/skills/triage-findings/SKILL.md | 44 +++++++++++++++++++ .../skills/triage-findings/agents/openai.yaml | 4 ++ README.md | 36 +++++++++++++++ 3 files changed, 84 insertions(+) create mode 100644 .codex/skills/triage-findings/SKILL.md create mode 100644 .codex/skills/triage-findings/agents/openai.yaml diff --git a/.codex/skills/triage-findings/SKILL.md b/.codex/skills/triage-findings/SKILL.md new file mode 100644 index 0000000..423d595 --- /dev/null +++ b/.codex/skills/triage-findings/SKILL.md @@ -0,0 +1,44 @@ +--- +name: triage-findings +description: Merge code-review findings, sort and renumber them by severity, resolve real issues, and move false positives into exclusions. +--- + +# Triage Findings + +## When To Use + +Use this skill when you receive multiple review findings, screenshots, comments, or issue lists that need to become one final triaged list. +It is also used when some findings are false positives and should be moved into the exclusions list. + +## Workflow + +1. Collect all findings into one list. +2. Merge duplicates into a single finding when they describe the same issue. +3. Sort the final list by severity: + - critical + - warning + - info +4. Renumber the sorted list from 1 upward. +5. Rewrite each finding concisely so the final list reads cleanly and consistently. +6. If a finding is a false positive, do not keep it in the final list. +7. Add false positives to the exclusions list using the existing schema in the repo or task context. + +## Resolution Flow + +After the list is merged and ordered, resolve the remaining findings one by one. + +1. Start from the highest severity item. +2. Identify the root cause in the relevant file or context. +3. Apply the smallest safe change that fixes the issue. +4. Add or update tests when behavior changes. +5. Re-check the issue after the change. +6. If the item is confirmed false positive, move it to exclusions instead of changing code. +7. Continue until the list is either fixed or explicitly excluded. + +## Output Rules + +- Keep the final findings list in severity order, then by any stable secondary order needed to make it readable. +- Keep numbering contiguous after filtering and merging. +- Preserve useful details like file path, location, and suggested fix. +- Keep exclusions entries minimal and consistent with the project schema. +- If the source already provides a severity or title, keep it unless it conflicts with the final ordering. diff --git a/.codex/skills/triage-findings/agents/openai.yaml b/.codex/skills/triage-findings/agents/openai.yaml new file mode 100644 index 0000000..6f59e2c --- /dev/null +++ b/.codex/skills/triage-findings/agents/openai.yaml @@ -0,0 +1,4 @@ +interface: + display_name: "Triage Findings" + short_description: "Triage, sort, fix, and exclude review findings" + default_prompt: "Use $triage-findings to merge review findings, sort and renumber them by severity, resolve real issues one by one, and add false positives to exclusions." diff --git a/README.md b/README.md index bf0f901..92c1000 100644 --- a/README.md +++ b/README.md @@ -199,3 +199,39 @@ jobs: pull-requests: write issues: write ``` + +## Skill：Triage Findings + +這份 skill 用來處理收到的 review 問題清單，流程是先合併成單一列表，再依嚴重度排序、重新編號，最後逐項修正或排除誤判。 + +### 規則 + +1. 先把所有問題合併成一個列表。 +2. 依嚴重度排序：`critical` -> `warning` -> `info`。 +3. 重新從 `1` 開始編號。 +4. 若問題屬於真實缺陷，就直接修正。 +5. 若問題是誤判，就加入 `.gitea/ai-review/exclusions.json`。 +6. 修正時以最小安全變更為原則，必要時補測試。 +7. 修正後要重新確認問題是否仍存在。 + +### 使用方式 + +在 Codex 裡直接用 `$triage-findings` 觸發，或直接描述你的需求，例如： + +1. 把收到的 review 問題貼給它。 +2. 要求它先合併、排序、重新編號。 +3. 要求它逐項修正真實問題。 +4. 如果某項是誤判，要求它加入 `.gitea/ai-review/exclusions.json`。 + +例如： + +- `請幫我整理這批 review 問題，合併後依嚴重度排序並重新編號` +- `這些問題裡哪些是誤判？請幫我加入 exclusions` +- `請依照合併後的列表逐項修正問題` + +### 適用情境 + +- 多張截圖或多段 review 結果需要整併 +- 問題清單需要重新排序與編號 +- 需要把誤判移出主要問題列表 +- 需要依清單逐項修正程式碼並補測試