Compare commits
6
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
2d2428a08c | ||
|
|
48d3089f1b | ||
|
|
7334a0f967 | ||
|
|
db65ca67d5 | ||
|
|
cd35d8b4ea | ||
|
|
68d844bfae |
@@ -150,5 +150,21 @@
|
|||||||
"reason": "已有等價防護:回應摘要先經 sanitizeLogText 去除控制字元(無法注入換行/ANSI 偽造 log),再截斷至 200 字;請求對象是參數檢查階段驗證過的 HTTPS Gitea 端點,非任意外部來源。保留截斷後的錯誤摘要對排查 API 失敗(如 403 權限訊息)必要,移除反而增加維運成本。",
|
"reason": "已有等價防護:回應摘要先經 sanitizeLogText 去除控制字元(無法注入換行/ANSI 偽造 log),再截斷至 200 字;請求對象是參數檢查階段驗證過的 HTTPS Gitea 端點,非任意外部來源。保留截斷後的錯誤摘要對排查 API 失敗(如 403 權限訊息)必要,移除反而增加維運成本。",
|
||||||
"source": "develop...master",
|
"source": "develop...master",
|
||||||
"date": "2026-07-15"
|
"date": "2026-07-15"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"location": "action.yml:40",
|
||||||
|
"role": "Maya",
|
||||||
|
"original_finding": "補一個整合測試或 action 介面測試,驗證執行時確實會把 `gitea.token` 帶進 `process.env.GITEA_TOKEN`,且不再依賴舊的 `RUNNER_TOKEN` 輸入。",
|
||||||
|
"reason": "專案目前沒有任何測試框架或 package.json,為 action 介面契約補整合測試需要先建立測試基礎設施,超出本次修正範圍(與既有多筆測試覆蓋類排除一致);此契約已由 CI 實際執行驗證(自動 token 成功清理 release/tag)。",
|
||||||
|
"source": "develop...ai-review-resolve/develop-20260715-133726",
|
||||||
|
"date": "2026-07-15"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"location": "src/index.js:426",
|
||||||
|
"role": "Maya",
|
||||||
|
"original_finding": "補一個有 token 的案例,驗證 log 只會出現 `[redacted]`,而實際送出的 header 會是 `token ${GITEA_TOKEN}`,同時不要把明文 token 暴露到輸出中。",
|
||||||
|
"reason": "專案目前沒有測試基礎設施,補授權分支的測試屬後續技術債(與既有多筆測試覆蓋類排除一致);遮蔽輸出為固定字面值 [redacted],不經任何插值,明文外洩風險已由程式結構排除。",
|
||||||
|
"source": "develop...ai-review-resolve/develop-20260715-133726",
|
||||||
|
"date": "2026-07-15"
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
|
|||||||
@@ -1,18 +1 @@
|
|||||||
[
|
[]
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Maya",
|
|
||||||
"location": "action.yml:40",
|
|
||||||
"problem": "這裡把 action 內注入的 token 改成 `GITEA_TOKEN`,但沒有任何測試去鎖住這個 workflow 契約;只要 YAML 欄位名稱或注入來源寫錯,程式就會默默退回匿名呼叫,錯誤很難被第一時間發現。",
|
|
||||||
"suggestion": "補一個整合測試或 action 介面測試,驗證執行時確實會把 `gitea.token` 帶進 `process.env.GITEA_TOKEN`,且不再依賴舊的 `RUNNER_TOKEN` 輸入。",
|
|
||||||
"is_new": true
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"level": "warning",
|
|
||||||
"role": "Maya",
|
|
||||||
"location": "src/index.js:426",
|
|
||||||
"problem": "有 token 時會改成記錄 redacted 訊息並建立 `Authorization` header,但目前看不到任何測試在保護這個授權分支;一旦 header 格式或遮蔽輸出出錯,就可能讓 API 請求失敗或把敏感值寫進 log。",
|
|
||||||
"suggestion": "補一個有 token 的案例,驗證 log 只會出現 `[redacted]`,而實際送出的 header 會是 `token ${GITEA_TOKEN}`,同時不要把明文 token 暴露到輸出中。",
|
|
||||||
"is_new": true
|
|
||||||
}
|
|
||||||
]
|
|
||||||
|
|||||||
+4
-4
@@ -1,5 +1,5 @@
|
|||||||
# 檔案用途:定義 CLEANUP OLD RELEASES 這個 Docker action 的輸入參數與執行環境
|
# 檔案用途:定義 CLEANUP OLD RELEASES 這個 Docker action 的輸入參數與執行環境
|
||||||
# 更新日期:2026/07/15 11:17:00
|
# 更新日期:2026/07/15 13:05:00
|
||||||
|
|
||||||
# Action 名稱,會顯示在 action 市集與文件中
|
# Action 名稱,會顯示在 action 市集與文件中
|
||||||
name: 'CLEANUP OLD RELEASES'
|
name: 'CLEANUP OLD RELEASES'
|
||||||
@@ -12,10 +12,10 @@ author: 'Jeffery'
|
|||||||
|
|
||||||
# 定義可由使用者或呼叫端傳入的輸入參數
|
# 定義可由使用者或呼叫端傳入的輸入參數
|
||||||
inputs:
|
inputs:
|
||||||
# KEEP_COUNT 用於控制保留的 release 數量
|
# KEEP_COUNT 用於控制保留的 release 數量;正式版與預發行版(prerelease)分組各自保留這個數量
|
||||||
KEEP_COUNT:
|
KEEP_COUNT:
|
||||||
# 參數說明,這裡表示保留的版本數量
|
# 參數說明,這裡表示每組(正式版/預發行版)各自保留的版本數量
|
||||||
description: '保留的版本數量'
|
description: '保留的版本數量(正式版與預發行版各自保留)'
|
||||||
# 預設保留 2 個版本,避免完全刪除歷史 release
|
# 預設保留 2 個版本,避免完全刪除歷史 release
|
||||||
default: '2'
|
default: '2'
|
||||||
|
|
||||||
|
|||||||
+12
-8
@@ -395,7 +395,7 @@ function hasBatchFailure(results) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* 執行 release 與 tag 清理流程。
|
* 執行 release 與 tag 清理流程;正式版與預發行版(prerelease)分組計算,各自保留最新 `KEEP_COUNT` 筆。
|
||||||
*/
|
*/
|
||||||
async function main() {
|
async function main() {
|
||||||
const GITEA_SERVER_URL = normalizeEnvValue(process.env.GITEA_SERVER_URL);
|
const GITEA_SERVER_URL = normalizeEnvValue(process.env.GITEA_SERVER_URL);
|
||||||
@@ -454,16 +454,21 @@ async function main() {
|
|||||||
return 0;
|
return 0;
|
||||||
});
|
});
|
||||||
|
|
||||||
const releaseCount = releaseJson.length;
|
const stableReleases = releaseJson.filter((item) => !item?.prerelease);
|
||||||
info(`RELEASE_COUNT=${releaseCount}`);
|
const preReleases = releaseJson.filter((item) => item?.prerelease);
|
||||||
|
|
||||||
|
info(`RELEASE_COUNT=${releaseJson.length}`);
|
||||||
|
info(`STABLE_COUNT=${stableReleases.length}`);
|
||||||
|
info(`PRERELEASE_COUNT=${preReleases.length}`);
|
||||||
info(`KEEP_COUNT=${KEEP_COUNT}`);
|
info(`KEEP_COUNT=${KEEP_COUNT}`);
|
||||||
|
|
||||||
if (releaseCount <= keepCount) {
|
const releaseToKeep = [...stableReleases.slice(0, keepCount), ...preReleases.slice(0, keepCount)];
|
||||||
|
const releaseToDelete = [...stableReleases.slice(keepCount), ...preReleases.slice(keepCount)];
|
||||||
|
|
||||||
|
if (releaseToDelete.length === 0) {
|
||||||
info('沒有需要清理的舊版本成品');
|
info('沒有需要清理的舊版本成品');
|
||||||
} else {
|
} else {
|
||||||
section('刪除舊版本成品');
|
section('刪除舊版本成品');
|
||||||
|
|
||||||
const releaseToDelete = releaseJson.slice(keepCount);
|
|
||||||
const releaseResults = await processInBatches(releaseToDelete, DELETE_CONCURRENCY, async (releaseItem) => {
|
const releaseResults = await processInBatches(releaseToDelete, DELETE_CONCURRENCY, async (releaseItem) => {
|
||||||
const releaseId = releaseItem?.id;
|
const releaseId = releaseItem?.id;
|
||||||
if (!Number.isSafeInteger(releaseId) || releaseId <= 0) {
|
if (!Number.isSafeInteger(releaseId) || releaseId <= 0) {
|
||||||
@@ -496,8 +501,7 @@ async function main() {
|
|||||||
section('刪除未指定 release 的 tag');
|
section('刪除未指定 release 的 tag');
|
||||||
|
|
||||||
const releaseTags = new Set(
|
const releaseTags = new Set(
|
||||||
releaseJson
|
releaseToKeep
|
||||||
.slice(0, keepCount)
|
|
||||||
.map((item) => item?.tag_name)
|
.map((item) => item?.tag_name)
|
||||||
.filter((tag) => !isEmptyOrNull(tag)),
|
.filter((tag) => !isEmptyOrNull(tag)),
|
||||||
);
|
);
|
||||||
|
|||||||
Reference in New Issue
Block a user