refactor: tidy cleanup release logs

Dockerfile

@@ -1,10 +1,8 @@
 FROM alpine:latest
 
-# 安裝必要的工具
 RUN apk add --no-cache --no-check-certificate bash curl jq
 
 COPY entrypoint.sh /entrypoint.sh
-
 RUN chmod +x /entrypoint.sh
 
 ENTRYPOINT ["/entrypoint.sh"]

entrypoint.sh

@@ -1,81 +1,117 @@
-#!/bin/bash
+#!/usr/bin/env bash
+set -Eeuo pipefail
 
-echo "=================================================="
+separator() {
+  printf '\n%s\n' '=================================================='
+}
 
-echo "參數檢查"
+section() {
+  separator
+  printf '%s\n' "$1"
+  printf '%s\n' '--------------------------------------------------'
+}
 
-echo "--------------------------------------------------"
+info() {
+  printf '[INFO] %s\n' "$1"
+}
 
-# 顯示 GITEA_SERVER_URL 參數，並檢查是否為空或 "null"，如果是則輸出錯誤訊息並退出
+success() {
-echo "GITEA_SERVER_URL=$GITEA_SERVER_URL" && ([ -z "$GITEA_SERVER_URL" ] || [ "$GITEA_SERVER_URL" = "null" ]) && exit 1
+  printf '[OK]   %s\n' "$1"
+}
 
-# 顯示 GITEA_REPOSITORY 參數，並檢查是否為空或 "null"，如果是則輸出錯誤訊息並退出
+warn() {
-echo "GITEA_REPOSITORY=$GITEA_REPOSITORY" && ([ -z "$GITEA_REPOSITORY" ] || [ "$GITEA_REPOSITORY" = "null" ]) && exit 1
+  printf '[WARN] %s\n' "$1"
+}
 
-# 顯示 RUNNER_TOKEN 參數
+fail() {
-echo "RUNNER_TOKEN=$RUNNER_TOKEN"
+  printf '[ERR]  %s\n' "$1" >&2
+}
 
-# 顯示 KEEP_COUNT 參數，並檢查是否為空或 "null"，如果是則輸出錯誤訊息並退出
+is_empty_or_null() {
-echo "KEEP_COUNT=$KEEP_COUNT" && ([ -z "$KEEP_COUNT" ] || [ "$KEEP_COUNT" = "null" ]) && exit 1
+  [ -z "${1:-}" ] || [ "${1:-}" = "null" ]
+}
 
-echo "=================================================="
+require_value() {
+  local name="$1"
+  local value="$2"
 
-echo "取得成品資訊"
+  info "$name=$value"
+  if is_empty_or_null "$value"; then
+    fail "$name is required"
+    exit 1
+  fi
+}
 
-echo "--------------------------------------------------"
+require_integer() {
+  local name="$1"
+  local value="$2"
 
-RELEASE_URL="$GITEA_SERVER_URL/api/v1/repos/$GITEA_REPOSITORY/releases"
+  if ! [[ "$value" =~ ^[0-9]+$ ]]; then
+    fail "$name must be a non-negative integer"
+    exit 1
+  fi
+}
 
-# 檢查是否為空或 "null"
+section "參數檢查"
-if [ -n "$RUNNER_TOKEN" ] && [ "$RUNNER_TOKEN" != "null" ]; then
+require_value "GITEA_SERVER_URL" "$GITEA_SERVER_URL"
-    # 組合 RELEASE_HEADER 參數，並顯示出來
+require_value "GITEA_REPOSITORY" "$GITEA_REPOSITORY"
-    RELEASE_HEADER="Authorization: token $RUNNER_TOKEN" && echo "RELEASE_HEADER=$RELEASE_HEADER"
+require_value "KEEP_COUNT" "$KEEP_COUNT"
+require_integer "KEEP_COUNT" "$KEEP_COUNT"
 
-    # 取得成品資訊
+if is_empty_or_null "${RUNNER_TOKEN:-}"; then
-    RELEASE_JSON="$(curl -s -H "$RELEASE_HEADER" "$RELEASE_URL")"
+  warn "RUNNER_TOKEN is empty; release API calls will be anonymous"
 else
-    # 取得成品資訊
+  info "RUNNER_TOKEN=[redacted]"
-    RELEASE_JSON="$(curl -s "$RELEASE_URL")"
 fi
 
-# 計算成品數量並依照時間排序
+release_api_url="$GITEA_SERVER_URL/api/v1/repos/$GITEA_REPOSITORY/releases"
-RELEASE_JSON=$(echo "$RELEASE_JSON" | jq -e 'sort_by(.created_at) | reverse')
+auth_header=()
-RELEASE_COUNT=$(echo "$RELEASE_JSON" | jq 'length') && echo "RELEASE_COUNT=$RELEASE_COUNT"
 
-# 檢查成品數量是否需要清除
+if ! is_empty_or_null "${RUNNER_TOKEN:-}"; then
-[ $RELEASE_COUNT -le $KEEP_COUNT ] && exit 0
+  auth_header=(-H "Authorization: token $RUNNER_TOKEN")
-
-echo "=================================================="
-
-echo "刪除舊版本的成品"
-
-echo "--------------------------------------------------"
-
-RELEASE_TO_DELETE=$(echo "$RELEASE_JSON" | jq -c ".[$KEEP_COUNT:]")
-
-echo "$RELEASE_TO_DELETE" | jq -c '.[]' | while IFS= read -r RELEASE_URL; do
-  # 檢查是否有成品連結
-  ([ -z "$RELEASE_URL" ] || [ "$RELEASE_URL" == "null" ]) && continue
-  
-  # 取得成品資訊
-  RELEASE_ID=$(echo "$RELEASE_URL" | jq -r '.id')
-  RELEASE_TAG=$(echo "$RELEASE_URL" | jq -r '.tag_name')
-  RELEASE_NAME=$(echo "$RELEASE_URL" | jq -r '.name')
-
-  # 檢查成品編號是否正確
-  ([ -z "$RELEASE_ID" ] || [ "$RELEASE_ID" == "null" ]) && continue
-
-  # 刪除成品
-  RELEASE_URL="$GITEA_SERVER_URL/api/v1/repos/$GITEA_REPOSITORY/releases/$RELEASE_ID"
-
-  RELEASE_DELETE_CODE=$(curl -s -o /dev/null -w "%{http_code}" -X DELETE -H "$RELEASE_HEADER" "$RELEASE_URL")
-
-  # 檢查刪除成品是否成功
-  if [ "$RELEASE_DELETE_CODE" -eq 204 ]; then
-    echo "✅ 成功刪除成品: $RELEASE_TAG ($RELEASE_NAME)"
-  else
-    echo "❌ 刪除成品失敗: $RELEASE_TAG ($RELEASE_NAME), HTTP 狀態碼: $RELEASE_DELETE_CODE"
 fi
-done
 
-echo "=================================================="
+section "取得成品資訊"
+info "GET $release_api_url"
+
+release_json="$(curl -fsS "${auth_header[@]}" "$release_api_url")"
+release_json="$(jq -e 'sort_by(.created_at) | reverse' <<<"$release_json")"
+release_count="$(jq 'length' <<<"$release_json")"
+
+info "RELEASE_COUNT=$release_count"
+info "KEEP_COUNT=$KEEP_COUNT"
+
+if [ "$release_count" -le "$KEEP_COUNT" ]; then
+  success "沒有需要清理的舊版本成品"
+  exit 0
+fi
+
+section "刪除舊版本成品"
+
+release_to_delete="$(jq -c ".[$KEEP_COUNT:]" <<<"$release_json")"
+
+while IFS= read -r release_item; do
+  [ -z "$release_item" ] && continue
+
+  release_id="$(jq -r '.id' <<<"$release_item")"
+  release_tag="$(jq -r '.tag_name' <<<"$release_item")"
+  release_name="$(jq -r '.name' <<<"$release_item")"
+
+  if is_empty_or_null "$release_id"; then
+    warn "略過沒有 id 的成品: $release_tag ($release_name)"
+    continue
+  fi
+
+  delete_url="$GITEA_SERVER_URL/api/v1/repos/$GITEA_REPOSITORY/releases/$release_id"
+  info "DELETE $release_tag ($release_name)"
+
+  delete_code="$(curl -sS -o /dev/null -w "%{http_code}" -X DELETE "${auth_header[@]}" "$delete_url")"
+
+  if [ "$delete_code" -eq 204 ]; then
+    success "成功刪除: $release_tag ($release_name)"
+  else
+    fail "刪除失敗: $release_tag ($release_name), HTTP $delete_code"
+  fi
+done < <(jq -c '.[]' <<<"$release_to_delete")
+
+separator