actions/calculate-version
2
0
Fork 0
Code Pull Requests Actions Releases 1 Activity

chore: update review exclusions

Browse Source
This commit is contained in:
Jeffery
2026-05-15 17:11:41 +00:00
parent be954f4cb1
commit 74c544d4e4
1 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.gitea/ai-review/exclusions.json
+18
View File
@@ -64,5 +64,23 @@
"role": "Leo", "role": "Leo",
"location": "entrypoint.sh:110", "location": "entrypoint.sh:110",
"suggestion": "`calculate_version` 中的 jq 腳本使用魔術數字 `10` 用於 patch >= 10 判斷。建議提取為具名常數，或改用 Bash `readonly` 常數。" "suggestion": "`calculate_version` 中的 jq 腳本使用魔術數字 `10` 用於 patch >= 10 判斷。建議提取為具名常數，或改用 Bash `readonly` 常數。"
},
{
"level": "warning",
"role": "Maya",
"location": "tests/entrypoint_test.sh:209",
"suggestion": "`next_release_version` 函數的測試案例涵蓋了：patch、minor 版本進位，但缺少 major 版本進位測試。例如：`99.9.9 -> 100.0.0`。建議新增此邊界條件測試，以確保版本號計算完整性。"
},
{
"level": "warning",
"role": "Maya",
"location": "tests/entrypoint_test.sh:209",
"suggestion": "目前測試案例中，雖然 `run_entrypoint` 函數接受 `token` 參數，但沒有明確測試驗證 `RUNNER_TOKEN` 存在時，`curl` 是否正確使用授權標頭。建議新增測試案例驗證 `RUNNER_TOKEN` 行為。"
},
{
"level": "warning",
"role": "Maya",
"location": "tests/entrypoint_test.sh:209",
"suggestion": "測試腳本執行過程中會建立暫存檔案與目錄：`response_file`、`workdir`，但目前沒有明確清理機制。可能導致測試環境累積不必要檔案。建議在測試腳本開頭或結尾加入：`trap 'rm -rf \"$workdir\" \"$response_file\"' EXIT`，以確保測試完成後所有暫存資源皆被妥善移除。"
} }
] ]